-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1153] Allow runtime switch of lightwalletd servers #1373
Merged
LukasKorba
merged 1 commit into
Electric-Coin-Company:main
from
LukasKorba:1153-Allow-runtime-switch-of-lightwalletd-servers
Feb 12, 2024
Merged
[#1153] Allow runtime switch of lightwalletd servers #1373
LukasKorba
merged 1 commit into
Electric-Coin-Company:main
from
LukasKorba:1153-Allow-runtime-switch-of-lightwalletd-servers
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Feb 9, 2024
…vers - new public API switchTo(endpoint:) implemented [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - API documented - code cleaned up [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - mocks generated [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - sever validation added
LukasKorba
force-pushed
the
1153-Allow-runtime-switch-of-lightwalletd-servers
branch
from
February 9, 2024 15:00
26128ae
to
7537b45
Compare
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Feb 9, 2024
…vers - new public API switchTo(endpoint:) implemented [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - API documented - code cleaned up [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - mocks generated [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - sever validation added [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - enhanced validation of the server
LukasKorba
force-pushed
the
1153-Allow-runtime-switch-of-lightwalletd-servers
branch
from
February 9, 2024 15:21
7537b45
to
6582c1b
Compare
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Feb 9, 2024
…vers - new public API switchTo(endpoint:) implemented [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - API documented - code cleaned up [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - mocks generated [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - sever validation added [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - enhanced validation of the server [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation
LukasKorba
force-pushed
the
1153-Allow-runtime-switch-of-lightwalletd-servers
branch
from
February 9, 2024 15:37
6582c1b
to
55a562a
Compare
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Feb 10, 2024
…vers - new public API switchTo(endpoint:) implemented [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - API documented - code cleaned up [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - mocks generated [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - sever validation added [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - enhanced validation of the server [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - ZcashError definition update
LukasKorba
force-pushed
the
1153-Allow-runtime-switch-of-lightwalletd-servers
branch
from
February 10, 2024 07:27
55a562a
to
403ae8a
Compare
HonzaR
reviewed
Feb 12, 2024
str4d
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 403ae8a.
Example/ZcashLightClientSample/ZcashLightClientSample/DemoAppConfig.swift
Show resolved
Hide resolved
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Feb 12, 2024
…vers - new public API switchTo(endpoint:) implemented [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - API documented - code cleaned up [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - mocks generated [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - sever validation added [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - enhanced validation of the server [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - ZcashError definition update [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - addressed comments
LukasKorba
force-pushed
the
1153-Allow-runtime-switch-of-lightwalletd-servers
branch
from
February 12, 2024 15:59
c566391
to
90e6c26
Compare
…vers - new public API switchTo(endpoint:) implemented [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - API documented - code cleaned up [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers - mocks generated [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - sever validation added [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - enhanced validation of the server [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - ZcashError definition update [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - addressed comments [Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373) - changelog revert according to proposal
LukasKorba
force-pushed
the
1153-Allow-runtime-switch-of-lightwalletd-servers
branch
from
February 12, 2024 16:13
90e6c26
to
c736905
Compare
str4d
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c736905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1153
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer