Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1153] Allow runtime switch of lightwalletd servers #1373

Conversation

LukasKorba
Copy link
Collaborator

Closes #1153

  • new public API switchTo(endpoint:) implemented
  • API documented
  • code cleaned up

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba LukasKorba requested review from str4d and HonzaR February 9, 2024 12:03
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Feb 9, 2024
…vers

- new public API switchTo(endpoint:) implemented

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- API documented
- code cleaned up

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- mocks generated

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- sever validation added
@LukasKorba LukasKorba force-pushed the 1153-Allow-runtime-switch-of-lightwalletd-servers branch from 26128ae to 7537b45 Compare February 9, 2024 15:00
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Feb 9, 2024
…vers

- new public API switchTo(endpoint:) implemented

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- API documented
- code cleaned up

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- mocks generated

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- sever validation added

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- enhanced validation of the server
@LukasKorba LukasKorba force-pushed the 1153-Allow-runtime-switch-of-lightwalletd-servers branch from 7537b45 to 6582c1b Compare February 9, 2024 15:21
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Feb 9, 2024
…vers

- new public API switchTo(endpoint:) implemented

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- API documented
- code cleaned up

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- mocks generated

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- sever validation added

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- enhanced validation of the server

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation
@LukasKorba LukasKorba force-pushed the 1153-Allow-runtime-switch-of-lightwalletd-servers branch from 6582c1b to 55a562a Compare February 9, 2024 15:37
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Feb 10, 2024
…vers

- new public API switchTo(endpoint:) implemented

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- API documented
- code cleaned up

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- mocks generated

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- sever validation added

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- enhanced validation of the server

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- ZcashError definition update
@LukasKorba LukasKorba force-pushed the 1153-Allow-runtime-switch-of-lightwalletd-servers branch from 55a562a to 403ae8a Compare February 10, 2024 07:27
Copy link
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 403ae8a.

LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Feb 12, 2024
…vers

- new public API switchTo(endpoint:) implemented

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- API documented
- code cleaned up

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- mocks generated

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- sever validation added

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- enhanced validation of the server

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- ZcashError definition update

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- addressed comments
@LukasKorba LukasKorba force-pushed the 1153-Allow-runtime-switch-of-lightwalletd-servers branch from c566391 to 90e6c26 Compare February 12, 2024 15:59
@LukasKorba LukasKorba requested review from str4d and HonzaR February 12, 2024 15:59
…vers

- new public API switchTo(endpoint:) implemented

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- API documented
- code cleaned up

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers

- mocks generated

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- sever validation added

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- enhanced validation of the server

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- new ZcashError.synchronizerServerSwitch that represents the state when the endpoint fails validation

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- ZcashError definition update

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- addressed comments

[Electric-Coin-Company#1153] Allow runtime switch of lightwalletd servers (Electric-Coin-Company#1373)

- changelog revert according to proposal
@LukasKorba LukasKorba force-pushed the 1153-Allow-runtime-switch-of-lightwalletd-servers branch from 90e6c26 to c736905 Compare February 12, 2024 16:13
Copy link
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c736905

@LukasKorba LukasKorba merged commit 09fe70d into Electric-Coin-Company:main Feb 12, 2024
2 checks passed
@LukasKorba LukasKorba deleted the 1153-Allow-runtime-switch-of-lightwalletd-servers branch April 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow runtime switch of lightwalletd servers
3 participants