-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
This github action makes use of original build tasks to create each of the artifacts and zips them up for easy consumption by the c# package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question to address
with: | ||
release_name: Milestone Release | ||
tag_name: v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a configurable var? is every release going to have this same tag? maybe I'm just not familiar with actions enough yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ordinarily yes. This release tag is usually pulled in from the branches tag. However, this isn't being started by a branch but by a milestone so there's no associated branch tag. If you look at the release that is made, you'll notice the tag isn't set because there isn't an existing v1.0.0
tag. I could try setting it to say untagged
if you prefer? If someone makes a tag called untagged
it'll start hooking up to that.
It's an oddity where the tag is required even if it's not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im just thinking that we'll have to update this when we update the milestone. would prefer to not do that, but it sounds like there isnt a good solution at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue was added to solve this: #28
Make install was failing and not completing. It is already installed on the system due to cmake. Removed the call for cleaner build logs.
Checklist
🚨Please review the guidelines for contributing to this repository.
Description
This github action makes use of original build tasks to create each of the artifacts and zips them up for easy consumption by the c# package
Here's an example:
https://github.com/microsoft/ElectionGuard-SDK-C-Implementation/releases/tag/untagged-674328eb13139d72db61
The build from this will update the badge on the Readme.
Closes #25
Closes #27