Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

🚀 Create Release Workflow #25

Merged
merged 4 commits into from
Nov 13, 2019
Merged

Conversation

keithrfung
Copy link
Contributor

@keithrfung keithrfung commented Nov 1, 2019

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • DO check open PR's to avoid duplicates.
  • DO keep pull requests small so they can be easily reviewed.
  • DO build locally before pushing.
  • DO make sure tests pass.
  • DO make sure any new changes are documented.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Description

This github action makes use of original build tasks to create each of the artifacts and zips them up for easy consumption by the c# package

Here's an example:
https://github.com/microsoft/ElectionGuard-SDK-C-Implementation/releases/tag/untagged-674328eb13139d72db61

The build from this will update the badge on the Readme.
Badge

Closes #25
Closes #27

This github action makes use of original build tasks to create each of the artifacts and zips them up for easy consumption by the c# package
Copy link
Contributor

@AddressXception AddressXception left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question to address

with:
release_name: Milestone Release
tag_name: v1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a configurable var? is every release going to have this same tag? maybe I'm just not familiar with actions enough yet

Copy link
Contributor Author

@keithrfung keithrfung Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ordinarily yes. This release tag is usually pulled in from the branches tag. However, this isn't being started by a branch but by a milestone so there's no associated branch tag. If you look at the release that is made, you'll notice the tag isn't set because there isn't an existing v1.0.0 tag. I could try setting it to say untagged if you prefer? If someone makes a tag called untagged it'll start hooking up to that.

It's an oddity where the tag is required even if it's not used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im just thinking that we'll have to update this when we update the milestone. would prefer to not do that, but it sounds like there isnt a good solution at the moment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was added to solve this: #28

AddressXception
AddressXception previously approved these changes Nov 5, 2019
keithrfung and others added 2 commits November 11, 2019 08:44
Make install was failing and not completing. It is already installed on the system due to cmake. Removed the call for cleaner build logs.
@echumley-msft echumley-msft merged commit b58fb18 into master Nov 13, 2019
@echumley-msft echumley-msft deleted the feature/release-workflow branch November 13, 2019 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build fails to install make
3 participants