-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeout to test-pylenium action #308
Conversation
testing if 60s timeout works correctly
test on my own branch was successful
This is great! Thanks for taking the time to create a PR. Let's see how the pipeline(s) do 😄 |
Poop... looks like the pipeline failed in the UI Tests step. Here's the job for more details: https://github.com/ElSnoMan/pyleniumio/actions/runs/5357935823/jobs/9723194411?pr=308 It shows that the
|
Sounds good, I'll start by increasing the timeout and then look for potential other options. Thanks for your time! |
Just wanted to check in on this - I added a commit to the PR that increased the timeout. Are there additional steps I should take? |
@abzdel I'm super sorry for just getting to this. You will need to merge |
No worries @ElSnoMan - just merged in main and added two commits (something in CI failed on the first run, but not when I pushed again - not sure why). Please let me know if any other changes are necessary |
The bug
UI tests sometimes fail during CI (fixes [GH Action] UI Tests sometimes fail with Selenoid #307)
Description of the Change
I added a timeout argument after selenoid starts up on the runner.
Verification
Tested on my own branch by changing the action trigger to ensure UI tests all passed. Then changed it back to its previous state once this was validated.
Release Notes
N/A
New to open source, open to any suggestions on how to improve this and/or future PRs!