Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout to test-pylenium action #308

Merged
merged 7 commits into from
Oct 8, 2023
Merged

Conversation

abzdel
Copy link
Contributor

@abzdel abzdel commented Jun 23, 2023

  1. The bug
    UI tests sometimes fail during CI (fixes [GH Action] UI Tests sometimes fail with Selenoid #307)

  2. Description of the Change
    I added a timeout argument after selenoid starts up on the runner.

name: Start Selenoid Server
# https://github.com/marketplace/actions/start-selenoid-server?version=v2
uses: Xotabu4/selenoid-github-action@v2
+    with:
+        selenoid-start-arguments: |
+        --args "-timeout 60s"
  1. Verification
    Tested on my own branch by changing the action trigger to ensure UI tests all passed. Then changed it back to its previous state once this was validated.

  2. Release Notes
    N/A

New to open source, open to any suggestions on how to improve this and/or future PRs!

@ElSnoMan
Copy link
Owner

This is great! Thanks for taking the time to create a PR. Let's see how the pipeline(s) do 😄

@ElSnoMan
Copy link
Owner

Poop... looks like the pipeline failed in the UI Tests step. Here's the job for more details: https://github.com/ElSnoMan/pyleniumio/actions/runs/5357935823/jobs/9723194411?pr=308

It shows that the page crashed for one of the tests which is relatively vague for our situation. Some ideas:

  • Increase the timeout to see if that stabilizes it
  • See what other config options for Selenoid exist in the GH Action that we can use

💡 I'm open to other ideas as well because nothing is "forcing" us to use Selenoid or this specific action

@ElSnoMan ElSnoMan added the chore Miscellaneous tasks for the repo/project label Jun 23, 2023
@abzdel
Copy link
Contributor Author

abzdel commented Jun 23, 2023

Sounds good, I'll start by increasing the timeout and then look for potential other options. Thanks for your time!

@abzdel
Copy link
Contributor Author

abzdel commented Jul 25, 2023

Just wanted to check in on this - I added a commit to the PR that increased the timeout. Are there additional steps I should take?

@ElSnoMan
Copy link
Owner

ElSnoMan commented Oct 6, 2023

@abzdel I'm super sorry for just getting to this. You will need to merge main into your branch and then send a new commit. If all passes, we're good to merge

@abzdel
Copy link
Contributor Author

abzdel commented Oct 6, 2023

No worries @ElSnoMan - just merged in main and added two commits (something in CI failed on the first run, but not when I pushed again - not sure why). Please let me know if any other changes are necessary

@ElSnoMan ElSnoMan merged commit c57f2f3 into ElSnoMan:main Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous tasks for the repo/project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GH Action] UI Tests sometimes fail with Selenoid
2 participants