Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): halt when multiple locations for read and write models and settings detected #5657

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Nov 9, 2024

Quick and nasty. Revisit in binary clean up.

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software labels Nov 9, 2024
@elecpower elecpower changed the title enh(cpn): detect multiple possible locations for read and write models and settings fix(cpn): detect multiple possible locations for read and write models and settings Nov 9, 2024
@pfeerick pfeerick changed the title fix(cpn): detect multiple possible locations for read and write models and settings fix(cpn): warn when multiple locations for read and write models and settings detected Nov 9, 2024
@pfeerick
Copy link
Member

pfeerick commented Nov 9, 2024

This only warns (with a scary, critical warning msgbox) right? It doesn't b0rk the read/write until the indeterminate location is fixed? Not asking for changes, just checking verbiage is correct ;) This could possibly be considered a feat(ure) rather than a (bug) fix, given it is alerting the user to what could be considered a configuration issue.

@pfeerick
Copy link
Member

pfeerick commented Nov 9, 2024

Deliberately separating this from the last comment as it's more about future planning/discussion. Not entirely sure of a reliable way to make this really lock on to the radio, without starting to check for multiple folders. As can't really rely on the .yml being present in case it's a new radio/SD that hasn't been booted yet. There is the sdcard version file, but obviously if it's a really old sd card pack, or someone has for whatever reason decided to delete that file, it's not much help.

What're your thoughts as to future fix... detect multiple possible paths, and show a drive picker, throwing the problem to the user to resolve (and become aware of)? Only other thing I can think of is a signature file/UUID that goes with each profile, and you look for that (as well?)...

@elecpower
Copy link
Collaborator Author

...and thus why I kept it crude at this point. Stop reading and writing from/to unexpected location.

The pick list is the way to go but the whole thing needs refactoring as the numerous checks that have been added over time are scattered thru the calls. Need to bring them back to the top level for an optimum user experience.

@pfeerick pfeerick changed the title fix(cpn): warn when multiple locations for read and write models and settings detected fix(cpn): halt when multiple locations for read and write models and settings detected Nov 10, 2024
@pfeerick
Copy link
Member

LGTM

Screencast.2024-11-11.09.46.45.mp4

@pfeerick pfeerick merged commit e871ad6 into main Nov 10, 2024
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-multiple-radio-locns branch November 10, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants