Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Warn on shutdown if trainer is connected #4212

Merged
merged 10 commits into from
Oct 23, 2023
Merged

feat: Warn on shutdown if trainer is connected #4212

merged 10 commits into from
Oct 23, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Oct 16, 2023

This adds a warning when trying to shutdown radio while a trainer is connected, as per @pfeerick comment in #3937

@pfeerick pfeerick changed the title feat: warn shutdown when trainer is connected feat: Warn on shutdown if trainer is connected Oct 16, 2023
@pfeerick pfeerick added the enhancement ✨ New feature or request label Oct 16, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 16, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 16, 2023 •
edited
Loading

I'll throw this out to the translators now since it should be a nice simple one...

Can we get some translations for this please 😃

Context: There is going to be a warning prompt on shutdown (similar to the USB connected, model still powered one) if the trainer link is still active, which would cover instances such as where the RF link doesn't provide telemetry.

#define TR_TRAINER_STILL_CONNECTED "Trainer still connected"

@froqstar
Copy link

DE:

#define TR_TRAINER_STILL_CONNECTED "Schüler noch verbunden";

@Eldenroot
Copy link
Contributor

CZ: Trenér stále připojen

@Pat6874
Copy link
Contributor

Pat6874 commented Oct 16, 2023 via email

@zandorsp
Copy link
Contributor

zandorsp commented Oct 16, 2023 •
edited by pfeerick
Loading

PT

"Trainer ainda conectado"

@robustini
Copy link
Contributor

IT

#define TR_TRAINER_STILL_CONNECTED "Trainer ancora connesso"

@ulfhedlund
Copy link
Contributor

SE
#define TR_TRAINER_STILL_CONNECTED "Lärare fortfarande ansluten"

@ajjjjjjjj
Copy link
Contributor

PL
#define TR_TRAINER_STILL_CONNECTED "Uczeń ciągle podłączony"

@offer-shmuely
Copy link
Contributor

HE

מצב חניך עדיין מחובר

@pfeerick pfeerick mentioned this pull request Oct 17, 2023
Merged
@HThuren
Copy link
Contributor

HThuren commented Oct 19, 2023

DA
#define TR_TRAINER_STILL_CONNECTED "Træner fortsat forbundet"

@zyren
Copy link
Contributor

zyren commented Oct 19, 2023

CN

#define TR_TRAINER_STILL_CONNECTED "教练信号未断开"

TW

#define TR_TRAINER_STILL_CONNECTED "教練信號未斷開"

@ToshihiroMakuuchi
Copy link
Contributor

JP:
#define TR_TRAINER_STILL_CONNECTED "トレーナー通信はまだ継続しています"

pfeerick
pfeerick reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3djc Are you happy with the changes I made?

@3djc
Copy link
Collaborator Author

3djc commented Oct 23, 2023

@3djc Are you happy with the changes I made?

Yes Sir, Yes !

@pfeerick pfeerick merged commit 16b9d72 into main Oct 23, 2023
37 checks passed
@pfeerick pfeerick deleted the 3djc/trainer-check-shutdown branch October 23, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick left review comments

Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.