-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores: update to LUA 5.3 #4203
base: main
Are you sure you want to change the base?
Conversation
Will it increase memory demand? Something is ringing in my head that 5.3 has 32bit numbers so it takes more mem. |
The current LUA version we are using only supports 64Bit floating point. So I expect the memory usage to be reduced. |
5b668ff
to
62bca82
Compare
Hi, what is the status of this? |
This will come with EdgeTX 3.0. we want to have one release where we combine multiple incompatible changes, to make life easier for the lua Devs. |
@raphaelcoeffic when you rebase pls ping me so I can make some tests. |
Rebased to current main; but having issues with crashes to EM and stack overflow in widgets. |
I've rebases this to current main and it seems to be working ok on the radios I've tested (B&W and Color). @raphaelcoeffic - I made one small change to ldump.c and lundump.c so that the .luac files generated by the simulator will work on the radio (tested on MacOS). This involves forcing the size_t size value in the header to 32 bits (commit 22219748). With this change the .luac files generated in the simulator and on the radio are identical. |
Compiled .luac files are smaller with 5.3.
|
Found it. Here is test scipt "test_53ioopen.lua"
But you can also put in LUA |
io.* library works now. I've made some inital tests comparing 2.10 LUA 5.2 and 2.11 LUA 5.3 using TX16S simulator.
Need to do same test with B&W target but that's not good sign as bigger apps like BF Config script already works woth memory limit. |
I'm seeing reduced memory usage for running scripts.
I can't do any detailed analysis of the memory usage on your toolbox scripts as I can't see the source code anywhere. |
Preview of what is coming for
3.0
...Current issues: