Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cpn): Align brightness settings with radio, Speaker Volume values #4156

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix(cpn): Align brightness settings with radio, Speaker Volume values #4156

merged 4 commits into from
Oct 16, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Oct 3, 2023 •
edited by pfeerick
Loading

  • Enforce Backlight ON >= Backlight OFF brightness levels
  • Set minimum value for Backlight OFF brightness to match radio settings
  • Don't allow 'Backlight Auto OFF' value to be set to 0 on color LCD radios
  • Use correct values for 'Speaker Volume'
  • Use correct default switch configuration for EL18

Companion fixes:
099a798 
- Enforce Backlight ON >= Backlight OFF brightness levels
- Set minimum value for Backlight OFF brightness to match radio settings
- Don't allow 'Backlight Auto OFF' value to be set to 0 on color LCD radios
- Use correct values for 'Speaker Volume'
@pfeerick pfeerick changed the title fix(cpn): Companion fixes fix(cpn): Align brightness settings with radio, correct Speaker Volume values Oct 3, 2023
@pfeerick pfeerick changed the title fix(cpn): Align brightness settings with radio, correct Speaker Volume values fix(cpn): Align brightness settings with radio, Speaker Volume values Oct 3, 2023
@pfeerick pfeerick added bug 🪲 Something isn't working companion Related to the companion software labels Oct 3, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 3, 2023
@philmoz
Copy link
Collaborator Author

philmoz commented Oct 3, 2023

Added fixes for importing Pots and Source values from 2.10 firmware - interim fix for #3982

Fix EL18/NV14 Pot names.
a473b5d 
Fix EL18 switch definitions.
@pfeerick pfeerick self-requested a review October 13, 2023 10:44
pfeerick
pfeerick approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as expected.

@pfeerick pfeerick merged commit d473fab into EdgeTX:main Oct 16, 2023
3 checks passed
@philmoz philmoz deleted the companion-fixes branch January 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
2 participants
@philmoz @pfeerick