-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for latest FrSky receivers #4077
Conversation
87001cd
to
417adda
Compare
I believe this obsoletes #4045. |
it does indeed |
da9c463
to
c1e8d68
Compare
Tested with a
|
I have an With my X9D+2019, the list of options for the pin outs stop at CH24 on the SR10+. With my X12S w/ISRM, I can see the S.PORT, SBUS out, and FBUS options on the SR10+. Everything seems functional with the X12S and all 3 receivers. |
You should be able to see "SBUS in" on the first pin as well. At least on the SR10+, not sure the others have that capability.
Could you please test if "SBUS in" and "FBUS" are indeed woking? |
I just tested CH1 set to But, it does not look like FBUS works. I can select FBUS and it saves it, but there is no output. This applies to all 3 receivers. I can re-bind them to my Tandem radio without resetting the RX and FBUS will work there. I tried S.Port and that seems to work fine. I also tried F.Port on the two Archer Plus RS receivers that also works. |
That probably means we need to send some unknown bit at some point.... Let's see what can be done. |
@rburrow87 strangely, I see some traffic at ~460kbps. That isn't F.PORT (which is 115kbps) nor SBUS (100kbps) nor S.PORT (57.6kbps). |
ELRS debug works at 460800 ... |
@mha1 offtopic! These are really some FBUS frames I'm seeing. This is on a Archer PLUS receiver (SR10+). The only strange thing is that the length announced is Edit: what I'm seeing is FBUS with 24 channels (see code supporting it in ArduPilot here). If I change the number of channels from 24 to 16, I'm seeing shorter frames that would be understood by iNav as well. @rburrow87 would you mind re-testing FBUS and set the number of channels to New trace with 16 channels: |
@rburrow87 , could you test X9D+ 2019, think it should be ok now |
It won't work on color lcd if the constants are not fixed |
aa65ddd
to
2f6a9ee
Compare
Might be worth considering, indeed.
Ok, it probably only supports 16 channels. ArduPilot seems to support 24 channels as well.
This should be fixed now. |
Looks good now! I tested with both my X9D+2019 and X12S w/ISRM. Though it seems like there's an issue with the ISRM-S-X10S in my X12S that I missed in the first round of testing since I had it muted. I get constant telemetry lost/recovered with all 3 receivers, plus a regular Archer RS. Is this already known? I can submit a bug report if not. The issue goes away with ETX 2.9.0, and I don't see an issue with the X9D+2019 with 2.9.0 or this test build. |
Doh, just noticed that when using an Archer RS, Archer Plus RS, or Archer Plus RSmini, I can no longer choose F.Port. The X9D+2019 only shows S.PORT and FBUS, but the X12S shows S.PORT twice and FBUS. And this X12S telemetry issue seems like a larger issue as I just noticed that with an external ELRS module, the connection speed in status jumps all over the place instead of staying fixed 500hz when using a 500hz mode. I will do some more testing and submit a bug report for that TX. |
c38215b
to
cea6ab9
Compare
There was an error in the strings, should be fixed now. Regarding the "telem lost/recovered" issue, I can see it as well on the test X10 Express with internal ISRM. Do I understand properly that you see this issue only the X12S, and not on the X9D+, right? Edit: this is definitely not related to this PR, I can see it on |
I think it's all good now! Checked both the X9D+2019 and X12s.
Correct, only an issue with the X12S. X9D+2019 seems solid. And that PR fixes it for me too! |
I can only try out the 212x64 side of things since my only ACCESS transmitter is the X9D+2019, but this apperas to be working fine with an Archer Plus SR10+ and Archer Plus GR6, as well as the older Archer GR8. However, should I not be able to OTA update both of these RX like I can the GR8? As for the both the Archer Plus RXs I'm only getting the option to update via SPort. Just checking if it's user error or if something still needs to be implemented. |
Will try to investigate (but without any access gear, it's a bit harder) |
Co-authored-by: Bertrand Songis <[email protected]> Co-authored-by: raphaelcoeffic <[email protected]>
Co-authored-by: Bertrand Songis <[email protected]> Co-authored-by: raphaelcoeffic <[email protected]>
This is a port from opentx/opentx@29dd63a