Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for latest FrSky receivers #4077

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Sep 21, 2023

This is a port from opentx/opentx@29dd63a

@3djc 3djc marked this pull request as draft September 21, 2023 07:21
@raphaelcoeffic
Copy link
Member

I believe this obsoletes #4045.

@3djc
Copy link
Collaborator Author

3djc commented Sep 21, 2023

I believe this obsoletes #4045.

it does indeed

@3djc 3djc marked this pull request as ready for review September 21, 2023 13:39
@pfeerick pfeerick added this to the 2.10 milestone Sep 22, 2023
@pfeerick pfeerick added the enhancement ✨ New feature or request label Sep 22, 2023
@pfeerick pfeerick linked an issue Sep 22, 2023 that may be closed by this pull request
1 task
@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Sep 26, 2023

Tested with a SR10+ and X10 Express:

  • SBUS out: ✅
  • SBUS 24: ✅
  • S.PORT: ✅

@rburrow87
Copy link

I have an Archer Plus SR10+, Archer Plus RS, and Archer Plus RS Mini.

With my X9D+2019, the list of options for the pin outs stop at CH24 on the SR10+.

With my X12S w/ISRM, I can see the S.PORT, SBUS out, and FBUS options on the SR10+. Everything seems functional with the X12S and all 3 receivers.

@raphaelcoeffic
Copy link
Member

With my X12S w/ISRM, I can see the S.PORT, SBUS out, and FBUS options on the SR10+.

You should be able to see "SBUS in" on the first pin as well. At least on the SR10+, not sure the others have that capability.

Everything seems functional with the X12S and all 3 receivers.

Could you please test if "SBUS in" and "FBUS" are indeed woking?

@rburrow87
Copy link

I just tested CH1 set to SBus in with another RX's SBus out connected to it and it does work!

But, it does not look like FBUS works. I can select FBUS and it saves it, but there is no output. This applies to all 3 receivers. I can re-bind them to my Tandem radio without resetting the RX and FBUS will work there.

I tried S.Port and that seems to work fine. I also tried F.Port on the two Archer Plus RS receivers that also works.

@raphaelcoeffic
Copy link
Member

But, it does not look like FBUS works. I can select FBUS and it saves it, but there is no output. This applies to all 3 receivers. I can re-bind them to my Tandem radio without resetting the RX and FBUS will work there.

That probably means we need to send some unknown bit at some point.... Let's see what can be done.

@raphaelcoeffic
Copy link
Member

@rburrow87 strangely, I see some traffic at ~460kbps. That isn't F.PORT (which is 115kbps) nor SBUS (100kbps) nor S.PORT (57.6kbps).

@mha1
Copy link
Contributor

mha1 commented Sep 27, 2023

ELRS debug works at 460800 ...

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Sep 27, 2023

@mha1 offtopic! These are really some FBUS frames I'm seeing. This is on a Archer PLUS receiver (SR10+).

FBUS+SBUS.zip

The only strange thing is that the length announced is 35 bytes, instead of 24 or 32, as it searched for in the iNav code (see here).

Edit: what I'm seeing is FBUS with 24 channels (see code supporting it in ArduPilot here). If I change the number of channels from 24 to 16, I'm seeing shorter frames that would be understood by iNav as well.

@rburrow87 would you mind re-testing FBUS and set the number of channels to 16 (in "Channel Range")? Also, could you please tell me what you used to test with that was hooked to FBUS?

New trace with 16 channels:
FBUS16+SBUS.zip

@3djc
Copy link
Collaborator Author

3djc commented Sep 27, 2023

@rburrow87 , could you test X9D+ 2019, think it should be ok now

@bsongis
Copy link
Contributor

bsongis commented Sep 27, 2023

It won't work on color lcd if the constants are not fixed

@raphaelcoeffic
Copy link
Member

Maybe it should be defaulting to the more standard 16 channels instead of 24? I did not realize there was FBUS-16ch and FBUS-24ch.

Might be worth considering, indeed.

I was testing FBUS with a Spirit GT heli FBL, one of the more modern FBL.

Ok, it probably only supports 16 channels. ArduPilot seems to support 24 channels as well.

@rburrow87 , could you test X9D+ 2019, think it should be ok now
I'm able to see and use the extra options on Pin1, but the rest of the pins still stop at CH16/24.

This should be fixed now.

@rburrow87
Copy link

@rburrow87 , could you test X9D+ 2019, think it should be ok now

I'm able to see and use the extra options on Pin1, but the rest of the pins still stop at CH16/24.

This should be fixed now.

Looks good now! I tested with both my X9D+2019 and X12S w/ISRM.

Though it seems like there's an issue with the ISRM-S-X10S in my X12S that I missed in the first round of testing since I had it muted. I get constant telemetry lost/recovered with all 3 receivers, plus a regular Archer RS. Is this already known? I can submit a bug report if not. The issue goes away with ETX 2.9.0, and I don't see an issue with the X9D+2019 with 2.9.0 or this test build.

@rburrow87
Copy link

Doh, just noticed that when using an Archer RS, Archer Plus RS, or Archer Plus RSmini, I can no longer choose F.Port. The X9D+2019 only shows S.PORT and FBUS, but the X12S shows S.PORT twice and FBUS.

And this X12S telemetry issue seems like a larger issue as I just noticed that with an external ELRS module, the connection speed in status jumps all over the place instead of staying fixed 500hz when using a 500hz mode. I will do some more testing and submit a bug report for that TX.

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Sep 29, 2023

Doh, just noticed that when using an Archer RS, Archer Plus RS, or Archer Plus RSmini, I can no longer choose F.Port. The X9D+2019 only shows S.PORT and FBUS, but the X12S shows S.PORT twice and FBUS.

There was an error in the strings, should be fixed now.

Regarding the "telem lost/recovered" issue, I can see it as well on the test X10 Express with internal ISRM. Do I understand properly that you see this issue only the X12S, and not on the X9D+, right?

Edit: this is definitely not related to this PR, I can see it on main as well. This PR seems to fix it for me: #4038

@rburrow87
Copy link

Doh, just noticed that when using an Archer RS, Archer Plus RS, or Archer Plus RSmini, I can no longer choose F.Port. The X9D+2019 only shows S.PORT and FBUS, but the X12S shows S.PORT twice and FBUS.

There was an error in the strings, should be fixed now.

I think it's all good now! Checked both the X9D+2019 and X12s.

Regarding the "telem lost/recovered" issue, I can see it as well on the test X10 Express with internal ISRM. Do I understand properly that you see this issue only the X12S, and not on the X9D+, right?

Edit: this is definitely not related to this PR, I can see it on main as well. This PR seems to fix it for me: #4038

Correct, only an issue with the X12S. X9D+2019 seems solid. And that PR fixes it for me too!

@pfeerick pfeerick modified the milestones: 2.10, 2.9.x Sep 29, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 9, 2023

I can only try out the 212x64 side of things since my only ACCESS transmitter is the X9D+2019, but this apperas to be working fine with an Archer Plus SR10+ and Archer Plus GR6, as well as the older Archer GR8. However, should I not be able to OTA update both of these RX like I can the GR8? As for the both the Archer Plus RXs I'm only getting the option to update via SPort. Just checking if it's user error or if something still needs to be implemented.

@3djc
Copy link
Collaborator Author

3djc commented Oct 9, 2023

Will try to investigate (but without any access gear, it's a bit harder)

@pfeerick pfeerick merged commit 5fd2261 into main Oct 9, 2023
37 checks passed
pfeerick pushed a commit that referenced this pull request Oct 10, 2023
Co-authored-by: Bertrand Songis <[email protected]>
Co-authored-by: raphaelcoeffic <[email protected]>
@pfeerick pfeerick modified the milestones: 2.9.x, 2.9.2 Oct 18, 2023
@craigywsm craigywsm mentioned this pull request Nov 21, 2023
1 task
MRC3742 pushed a commit to MRC3742/edgetx that referenced this pull request Dec 22, 2023
Co-authored-by: Bertrand Songis <[email protected]>
Co-authored-by: raphaelcoeffic <[email protected]>
@pfeerick pfeerick deleted the 3djc/frsky-receiver-update branch January 26, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrSky ARCHER PLUS R10+ and SR10+ receiver support
7 participants