Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GitPod container image now needs their workspace image as base #4065

Merged
merged 4 commits into from
Sep 27, 2023
Merged

fix: GitPod container image now needs their workspace image as base #4065

merged 4 commits into from
Sep 27, 2023

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Sep 19, 2023 •
edited
Loading

This PR changes the Gitpod container image used as we need to use their base image.

See EdgeTX/build-edgetx#20

Please note: this PR is for testing only. It needs some edits before being merged. EdgeTX/build-edgetx#20 should be merged first.

@raphaelcoeffic
Copy link
Member Author

Test link: https://gitpod.io/#https://github.com/edgetx/edgetx/tree/2.9-gitpod-workspace

@rotorman
Copy link
Member

when testing build for TX16S, got an error about libclang not found.

rotorman
rotorman approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@rotorman rotorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works now.

@raphaelcoeffic raphaelcoeffic linked an issue Sep 20, 2023 that may be closed by this pull request
Build FW in Browser with gitpod currently not possible #4053
Closed
1 task
@raphaelcoeffic raphaelcoeffic mentioned this pull request Sep 20, 2023
Closed
1 task
@pfeerick pfeerick added this to the 2.9.1 milestone Sep 23, 2023
pfeerick
pfeerick approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me to build TX16S and TLite firmware. Probably just need a tagged 2.9.1 edgetx-build this can be pointed to since the referenced PR has been merged?

@raphaelcoeffic raphaelcoeffic changed the title Test gitpod container image feat: gitpod container image Sep 27, 2023
@pfeerick pfeerick added bug 🪲 Something isn't working and removed don't merge labels Sep 27, 2023
pfeerick added a commit that referenced this pull request Sep 27, 2023
@pfeerick
chore: Update gitpod config to use new workspace image (#4065)
b1d01f1 
Changes on GitPod's side required updated build images on our side which are based on their workspace image.
@pfeerick pfeerick changed the title feat: gitpod container image fix: GitPod container image now needs their workspace image as base Sep 27, 2023
@pfeerick pfeerick merged commit 41f779f into 2.9 Sep 27, 2023
34 checks passed
@pfeerick pfeerick deleted the 2.9-gitpod-workspace branch September 27, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotorman rotorman rotorman approved these changes

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.

Build FW in Browser with gitpod currently not possible
3 participants
@raphaelcoeffic @rotorman @pfeerick