Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(radio): Cleanup startup code. #4027

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Sep 8, 2023

Fixes #4018

Summary of changes:

  • Remove SPLASH build option
  • Move splash handling code to gui files/folders
  • Rename opentxXXX functions to edgeTxXXX
  • Fix throttle warning startup timing (haptic played before splash screen finished on color LCD)
  • Use radio setting to control startup/shutdown haptic

@MRC3742
Copy link
Contributor

MRC3742 commented Sep 9, 2023

I have tested this branch on a T16 and works as described.
Startup/down haptic is properly suppressed when ONLY "Quiet" mode is selected.

Just a thought for possible addition to this PR.
(1) Shut off Startup/down haptic when EITHER the "Alarm" or "Quiet" mode is selected?
(2) Or could an option be added, under the haptic menu, to turn it off/on at startup?

Thank You - Rich

haptic

@LS-67
Copy link

LS-67 commented Sep 29, 2023

In which version of ETX will this modification be implemented?

@pfeerick pfeerick added the house keeping 🧹 Cleanup of code and house keeping label Oct 3, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 3, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 3, 2023

@LS-67 2.10

Would the suggestion by Rich which implemented in this PR as no haptic on startup or shutdown if set to Quiet be sufficient for you? As that could possibly be added for 2.9.

@LS-67
Copy link

LS-67 commented Oct 3, 2023

This will suit me very well ! Thank's a lot !

@pfeerick pfeerick self-requested a review October 13, 2023 10:40
@pfeerick pfeerick added the enhancement ✨ New feature or request label Oct 15, 2023
Copy link
Member

@raphaelcoeffic raphaelcoeffic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, @3djc please review the STDLCD part.

@raphaelcoeffic raphaelcoeffic requested a review from 3djc October 27, 2023 06:59
Phil Mitchell added 5 commits November 5, 2023 17:51
- Remove SPLASH build option
- Move splash handling code to gui files/folders
- Rename opentxXXX functions to edgeTxXXX
- Fix throttle warning startup timing
- Use radio setting to control startup/shutdown haptic
…(matches B&W code).

Ensures LED always goes green after startup.
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on TX16S, X9D+, Pocket

pfeerick added a commit that referenced this pull request Nov 5, 2023
@pfeerick pfeerick merged commit 7190f00 into EdgeTX:main Nov 5, 2023
37 checks passed
richardclli added a commit that referenced this pull request Nov 6, 2023
pfeerick pushed a commit that referenced this pull request Nov 7, 2023
pfeerick pushed a commit that referenced this pull request Nov 7, 2023
pfeerick pushed a commit that referenced this pull request Nov 10, 2023
pfeerick pushed a commit that referenced this pull request Nov 12, 2023
pfeerick pushed a commit that referenced this pull request Nov 12, 2023
richardclli added a commit that referenced this pull request Nov 14, 2023
richardclli added a commit that referenced this pull request Nov 15, 2023
richardclli added a commit that referenced this pull request Nov 17, 2023
richardclli added a commit that referenced this pull request Nov 17, 2023
richardclli added a commit that referenced this pull request Nov 20, 2023
richardclli added a commit that referenced this pull request Nov 20, 2023
richardclli added a commit that referenced this pull request Nov 21, 2023
richardclli added a commit that referenced this pull request Nov 24, 2023
richardclli added a commit that referenced this pull request Nov 28, 2023
richardclli added a commit that referenced this pull request Nov 30, 2023
richardclli added a commit that referenced this pull request Dec 3, 2023
richardclli added a commit that referenced this pull request Dec 4, 2023
@philmoz philmoz deleted the startup-cleanup branch February 7, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TX 16 S EdgeTX 2.9 How to remove the vibrator when switching on the transmitter?
6 participants