-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert PPM_UNIT build option to runtime radio setting #3993
Conversation
@philmoz Woah! That was fast! I have only one remark: we should probably have |
If no PPM_UNIT is specified in the build options it defaults to PPM_UNIT_PERCENT_PREC0 (no decimal). |
Ok, my bad :-D |
Indeed, it was changed fairly recently, as PREC1 really doesn't give any benefit |
d09de71
to
c3172bc
Compare
LGTM, and I love how this seems to have ended up with slightly smaller firmware for both colorlcd and b&w then main (after rebasing and self-compiling)!! Also shows up where the colorlcd UI has very support for the PPM_UNIT option. Tested on X9D+2019 w/ Companion sync, as well as TX16S, 128x64 only simulator tested. |
WhooHoo! Hadn't followed up on my #3163, waiting till flying season was over to see if anything has happened - either fix the build process, or add an enhancement. Very happy to see this coming in 2.10! Thank you! |
Unfortunately, not what was asked for in #3163 - was expecting to see ppmus values in max/min under outputs, as can be done with selecting the build option for OpenTX. Per #3163, prior custom build for ppmus did not work. Have not tested custom build to see if that issue has been resolved in ver 2.10 rc4. |
Well, only half of what was asked (although probably the more important half)... it is now no longer a build time option, but a runtime option, but I don't think controls have been converted over fully on colorlcd. B&W radios should honor the setting better. This will need a new issue now (done: #4977), as the old one is no longer correct since it is not a build time option any more. I don't think |
Replace the PPM_UNIT build option with runtime code and a setting in the radio data for option selection.
B&W radios, color radios and companion updated.