Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lua): generate keys definitions #3923

Merged
merged 1 commit into from
Dec 20, 2023
Merged

chore(lua): generate keys definitions #3923

merged 1 commit into from
Dec 20, 2023

Conversation

raphaelcoeffic
Copy link
Member

No description provided.

@pfeerick pfeerick self-requested a review September 22, 2023 09:11
@pfeerick pfeerick added this to the 2.10 milestone Oct 3, 2023
@pfeerick pfeerick added the needs: rebase A git rebase on top of the latest destination branch version is required label Oct 13, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 13, 2023 •
edited
Loading

@raphaelcoeffic Rebasing this will give you a chance to kick the defined(USE_TRIMS_AS_BUTTOS) line that snuck in via that other PR (which should probably be USE_HATS_AS_KEYS). I'm staying well away from this one as I don't know how to factor that in in the jinja file 🤭 .

For the testing, you just want to know if the correct events fire, and if they still fire? As Robert's DevTools should help with that.

@pfeerick pfeerick added the lua label Oct 13, 2023
@raphaelcoeffic
Copy link
Member Author

For the testing, you just want to know if the correct events fire, and if they still fire? As Robert's DevTools should help with that.

That is the idea, but I would give him the opportunity to check himself, as I know he will complain afterwards otherwise :-D

@JimB40
Copy link
Collaborator

JimB40 commented Oct 15, 2023

Wondeful opportunity. To be frank seen better ones 😛

@pfeerick
Copy link
Member

@raphaelcoeffic Just a friendly reminder that this is still here... wanna do that rebase for me, and take care of the
defined(USE_TRIMS_AS_BUTTOS) which should probably be USE_HATS_AS_KEYS?

@pfeerick pfeerick removed the needs: rebase A git rebase on top of the latest destination branch version is required label Nov 19, 2023
@pfeerick pfeerick merged commit 6b1256d into main Dec 20, 2023
39 checks passed
@pfeerick pfeerick deleted the lua-keys branch December 20, 2023 11:28
@pfeerick pfeerick changed the title chores(lua): generate keys definitions chore(lua): generate keys definitions Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick Awaiting requested review from pfeerick

Assignees
No one assigned
Labels
lua needs: testing
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@raphaelcoeffic @pfeerick @JimB40