Interactive/progressive checklist #3564

gagarinlg · 2023-05-06T10:45:27Z

rebased, fixed and LVGL converted replacement for #1417

copied from #1417:
Summary of changes:
Adds an option to display check-boxes at the beginning of each checklist / model notes line.

Item to be currently processed has selected (active) check-box, confirmed item - selected checkbox, unconfirmed item - empty.
You can only advance by one in the checklist (by clicking ENTER - rotary encoder click).
You can normally scroll the checklist if it exceeds screen size and in addition it is automatically scrolled when currently processed item is at the bottom (or row above bottom) and there are more items available.
You can remove displaying and processing of some items by placing = sign as a first character in a line
You can mark only items, that are displayed on a screen (no off-screen item confirmation)
Interactive checklist loaded on model selection (and after reset flight) might be closed only when complete (additional ENTER click after last item completed), see Checkable preflight-checklist #133
Interactive checklist loaded from View Notes is closed by pressing EXIT/RTN, no check-boxes are displayed in the view.

Fixes #133

example checklist file

EdgeTX
=is
the
best
=and
=this
is interactive
checklist
=with some items disabled and now a very long line to test what happens then
EdgeTX
=is
the
best
=and
=this
is interactive
checklist
=with some items disabled

Eldenroot · 2023-05-07T14:30:58Z

Great! Thx for rebasing + other fixes :)

One of a long opened PR... really interesting new feature. There are more form @piotrva

philmoz · 2023-07-09T00:48:48Z

Model setup menu on B&W radios is broken. There are blank lines and the scrolling is not consistent.
The MENU_TAB array in menuModelSetup looks wrong.

philmoz

Needs to be done for 212x64 as well.

3djc · 2023-07-10T07:55:59Z

Needs to be done for 212x64 as well.

Indeed, was asked to fix 128, but yes, 212 was broken in several ways. Fixed it (but havent tested the feature itself at all on either platform)

philmoz · 2023-07-10T22:37:26Z

A couple of things;

On B&W radios the ENTER button exits the checklist after the last item is checked. On color radios the ENTER button toggles the last entry off again.
Long text lines do not wrap on either B&W or color radios.

I wonder if there should be a 'Close' button somewhere on the screen for color radios. It was not immediately obvious to me how to close the text viewer on a radio without hardware keys (NV14). This could trip up new users. A 'Close' button that only shows when the list is complete would also give something to focus on for the ENTER key to close the checklist.

Update: the issue with the checklist not loading on B&W radio startup is a simulator bug.

philmoz · 2023-07-11T02:41:16Z

I've made some changes to the color checklist code in PR #3787

philmoz · 2023-07-13T00:12:09Z

In PR #3787 I've indented the checkboxes for easier touch activation and also kept the 'RTN' button visible so the last checkbox is further away from the bottom of the screen.

Eldenroot · 2023-08-03T09:52:48Z

Maybe some graphic separation between check boxes when you use longer text?

pfeerick · 2023-08-03T10:04:16Z

Keeping in mind the list used to generate it was

is interactive
checklist
=with some items disabled and now a very long line to test what happens then
EdgeTX
=is

it may be better to first check what happens if there is a blank line. If that is correctly rendered, IMO it would be better to leave the formatting up to the checklist author.

pfeerick · 2023-08-03T10:06:57Z

i.e.

Eldenroot · 2023-08-05T08:58:49Z

Yes, because when you have more lines and tge check box is aligned to the middle...it could be confusing.

pfeerick · 2023-08-05T09:14:05Z

This can be controlled by the checklist author... I added a blank line in the checklist file - at line 10, and it was correctly displayed. So if you want spaces, add them. And if you don't, don't put them in?

raphaelcoeffic · 2023-08-12T05:49:35Z

@gagarinlg @pfeerick what is the status of this PR? Can we engage into the merge train?

gagarinlg · 2023-08-12T05:56:41Z

Should be OK after a rebase

raphaelcoeffic · 2023-08-12T06:56:17Z

Should be OK after a rebase

will you?

gagarinlg · 2023-08-12T07:01:31Z

Not this week

…n screen size

cannot exit menu from menuTextView as level above there is while loop that cannot be stopped from thic place in code

This is also crucial when it comes to analyse non-checkable items on a checklist, as in this way there is no need to load non-visible items from SD-card

… radios currently no automatic line wrapping and you can always exit the checklist, even when it is not fully done

* Move checklist logic to sub-class. Show model name instead of file name in title, show 'Preflight checks' in title2 for checklist. Handle long line wrapping of text. Don't indent lines without checkbox. Add 'RTN' button when done. * Code cleanup. * Simplify code by storing a list of checkboxes instead of scanning LVGL object hierarchy. * Indent checkboxes to make touch activation easier. Keep 'RTN' button visible so last checkbox is further from bottom of screen (for touch activation). 'RTN' button is disabled until checklist complete.

pfeerick · 2023-08-28T09:05:43Z

@philmoz Did something change in the checkbox handling recently? When I did the rebase, I only needed to make two changes in preflight_checks.cpp due to the CheckBox -> ToggleSwitch name changing... i.e.

new CheckBox(line, rect_t{}, GET_SET_DEFAULT(g_model.checklistInteractive));

to

auto interactiveChkList = new ToggleSwitch(line, rect_t{}, GET_SET_DEFAULT(g_model.checklistInteractive));

But the checkboxes in the preflight checks text viewer are now not visible on TX16S 🤔

philmoz · 2023-08-28T10:32:44Z

But the checkboxes in the preflight checks text viewer are now not visible on TX16S 🤔

Needed a class constructor for the LVGL checkbox (for the libopenui refactor stuff).

~~For some reason the checkbox is slightly smaller with this version - still investigating as to why.~~

pfeerick · 2023-08-28T10:40:58Z

Thanking you so much! :) I'll try and look at this in the morning, otherwise, it'll be tomorrow evening I'll be hoping to merge this in.

pfeerick · 2023-08-29T09:17:57Z

Ok, is working good again. TX16S and TPro seem ok on repeat testing.

* initial version of clickable checklist * do not display checkboxes for empty lines if checklist is shorter than screen size * remove checklist exit after completing it cannot exit menu from menuTextView as level above there is while loop that cannot be stopped from thic place in code * menu entry to enable and disable interactive checklist * only when complete interactive checklist is closed * config updated & not display checkboxes when entered from "View Notes" * add setup entry for colorlcd * do not make interactive checkist when loaded from menu * fix datastruct size after merge * Companion support for interactive checklist * mark checklist lines as non-checkable with '=' for B&W radios * Process only items visible on screen This is also crucial when it comes to analyse non-checkable items on a checklist, as in this way there is no need to load non-visible items from SD-card * WIP fix merge problems * update yaml datastructs * restore most functionalities for interactive check lists on color LCD radios currently no automatic line wrapping and you can always exit the checklist, even when it is not fully done * finalise interactive checklists for color LCD * fix: rebase/merge issues * fix: model setup checklist section * fix: fix 212 model setup * Re-work of the some of the color lcd checklist code (#3787) * Move checklist logic to sub-class. Show model name instead of file name in title, show 'Preflight checks' in title2 for checklist. Handle long line wrapping of text. Don't indent lines without checkbox. Add 'RTN' button when done. * Code cleanup. * Simplify code by storing a list of checkboxes instead of scanning LVGL object hierarchy. * Indent checkboxes to make touch activation easier. Keep 'RTN' button visible so last checkbox is further from bottom of screen (for touch activation). 'RTN' button is disabled until checklist complete. * Add checkbox class constructor for preflight checks. * Fix checkbox size. --------- Co-authored-by: Piotr Rzeszut <[email protected]> Co-authored-by: 3djc <[email protected]> Co-authored-by: philmoz <[email protected]> Co-authored-by: Phil Mitchell <[email protected]>

gagarinlg mentioned this pull request May 6, 2023

Interactive/progressive checklist #1417

Closed

gagarinlg added this to the 2.10 milestone May 6, 2023

gagarinlg force-pushed the bw-progressive-checklist branch from c77db8f to 112691b Compare May 29, 2023 09:12

gagarinlg force-pushed the bw-progressive-checklist branch from 112691b to 432e358 Compare July 8, 2023 10:06

philmoz reviewed Jul 9, 2023

View reviewed changes

pfeerick self-requested a review August 3, 2023 02:57

pfeerick force-pushed the bw-progressive-checklist branch from 10d4662 to c5a6a13 Compare August 3, 2023 04:53

raphaelcoeffic added enhancement ✨ New feature or request needs: rebase A git rebase on top of the latest destination branch version is required labels Aug 12, 2023

raphaelcoeffic marked this pull request as draft August 12, 2023 05:50

piotrva added 5 commits August 28, 2023 18:00

initial version of clickable checklist

5cf8b7f

do not display checkboxes for empty lines if checklist is shorter tha…

74b31e8

…n screen size

remove checklist exit after completing it

6eb079d

cannot exit menu from menuTextView as level above there is while loop that cannot be stopped from thic place in code

menu entry to enable and disable interactive checklist

ee531b9

only when complete interactive checklist is closed

86865ed

piotrva and others added 15 commits August 28, 2023 18:00

config updated & not display checkboxes when entered from "View Notes"

4df7c77

add setup entry for colorlcd

6725779

do not make interactive checkist when loaded from menu

38fb36b

fix datastruct size after merge

725df9c

Companion support for interactive checklist

a916e5c

mark checklist lines as non-checkable with '=' for B&W radios

aed6ba2

Process only items visible on screen

701ae50

This is also crucial when it comes to analyse non-checkable items on a checklist, as in this way there is no need to load non-visible items from SD-card

WIP fix merge problems

49fadc1

update yaml datastructs

132af0e

restore most functionalities for interactive check lists on color LCD…

b3771d9

… radios currently no automatic line wrapping and you can always exit the checklist, even when it is not fully done

finalise interactive checklists for color LCD

b5ce72c

fix: rebase/merge issues

ed0c277

fix: model setup checklist section

e76ea24

fix: fix 212 model setup

028422d

pfeerick force-pushed the bw-progressive-checklist branch from 3254b72 to 4292b2c Compare August 28, 2023 08:07

pfeerick removed the needs: rebase A git rebase on top of the latest destination branch version is required label Aug 28, 2023

pfeerick marked this pull request as ready for review August 28, 2023 08:08

Add checkbox class constructor for preflight checks.

7d982f4

Fix checkbox size.

f2e7969

pfeerick merged commit 06712d9 into main Aug 29, 2023
39 checks passed

pfeerick deleted the bw-progressive-checklist branch August 29, 2023 09:18

philmoz mentioned this pull request Oct 6, 2023

Checklist displayed as [fullscreen] widget #1222

Open

pfeerick mentioned this pull request Mar 11, 2024

chore: translation catchup for v2.10 #4613

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interactive/progressive checklist #3564

Interactive/progressive checklist #3564

gagarinlg commented May 6, 2023 •

edited

Loading

Eldenroot commented May 7, 2023

philmoz commented Jul 9, 2023

philmoz left a comment

3djc commented Jul 10, 2023

philmoz commented Jul 10, 2023 •

edited

Loading

philmoz commented Jul 11, 2023

philmoz commented Jul 13, 2023

Eldenroot commented Aug 3, 2023

pfeerick commented Aug 3, 2023

pfeerick commented Aug 3, 2023

Eldenroot commented Aug 5, 2023

pfeerick commented Aug 5, 2023 •

edited

Loading

raphaelcoeffic commented Aug 12, 2023

gagarinlg commented Aug 12, 2023

raphaelcoeffic commented Aug 12, 2023

gagarinlg commented Aug 12, 2023

pfeerick commented Aug 28, 2023

philmoz commented Aug 28, 2023 •

edited

Loading

pfeerick commented Aug 28, 2023

pfeerick commented Aug 29, 2023

Interactive/progressive checklist #3564

Interactive/progressive checklist #3564

Conversation

gagarinlg commented May 6, 2023 • edited Loading

Eldenroot commented May 7, 2023

philmoz commented Jul 9, 2023

philmoz left a comment

Choose a reason for hiding this comment

3djc commented Jul 10, 2023

philmoz commented Jul 10, 2023 • edited Loading

philmoz commented Jul 11, 2023

philmoz commented Jul 13, 2023

Eldenroot commented Aug 3, 2023

pfeerick commented Aug 3, 2023

pfeerick commented Aug 3, 2023

Eldenroot commented Aug 5, 2023

pfeerick commented Aug 5, 2023 • edited Loading

raphaelcoeffic commented Aug 12, 2023

gagarinlg commented Aug 12, 2023

raphaelcoeffic commented Aug 12, 2023

gagarinlg commented Aug 12, 2023

pfeerick commented Aug 28, 2023

philmoz commented Aug 28, 2023 • edited Loading

pfeerick commented Aug 28, 2023

pfeerick commented Aug 29, 2023

gagarinlg commented May 6, 2023 •

edited

Loading

philmoz commented Jul 10, 2023 •

edited

Loading

pfeerick commented Aug 5, 2023 •

edited

Loading

philmoz commented Aug 28, 2023 •

edited

Loading