-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoarETX V2 improvements and support for F3J/F5J 4-servo wing templates #126
Conversation
1. Fix GetCurve logic to detect if it is affected by the bug in some ETX versions, and correct as needed. this is for backward compatibility 2. V2: Added F3J and F5J templates and configuration. The templates came from SoarOTX and are compatible. 3. V2: Reorganize the code so that we don't have a proliferation of file. For example, in V1 there was separate LUA for the Mixers for each type of Glider, in V2 instead, a glider type parameter is passed, and initialize the proper content of the menu depending of the glider type. V2: Added SOUNDS who are specific for gliders.
Generally sounds (looks?) good to me. It may be better to include the sounds through the main sound pack... i.e. https://github.com/EdgeTX/edgetx-sdcard-sounds ... then these will be available sounding the same as the rest of the phrases for for at minimum the different UK/US EN voice packs? |
Will do separate SOUNDS.. you are right, that was one think that it did not feel right, since it will not work on multi-language. |
Will instead be included via the sound pack in EdgeTX/edgetx-sdcard-sounds#100
I'll probably have a look at this in the morning or perhaps the day after, but let me know if you are happy with the sound pack phases or want any changes... just needs different text in the |
Thank you, i was looking to generate them via Azure. Will take a look and adapt as needed. |
@frankiearzu - If you need someone to test the SoarETX v2 I am happy to help if I can. I have used SoarOTX for both F3K, F3J, F5J and F3RES planes and have one older radio (FrSky QX7) still running OpenTX because of that. I run ETX and can test on Xlite and TX16S. |
@ulfhedlund Thanks Ulf, I have a Zip with the new code that some friends and myself are using. Will change some of the sound names in special functions, but everything else will be the same. The V1 is backward compatible, if you already use a V1 model, it will continue working the same, You can download the SoarETX V2 Zip from here: |
Shall I merge this as it is now, and the changes the sound pack, or is more work needed on this (for this revision at least... it never ends! 🤣 ) |
Testing using some of the standard sounds, and adding some to the common path. |
No problem, just checking for a pulse ;) |
@pfeerick ALL Done!!! The sounds PR is at: |
After talking with the original Author.. he was OK with me doing the enhancements. Looks like he moved to Jeti Radio and will not spend much time enhancing the ETX version.
The V1 and V2 code are stored in different sub-directories, and the appropriate code will be run depending on the version used in the parameter of the main.lua for the widget. Both can co-exist. V1 totally backward compatible, and besides just updating the LUA Widgets, it will work with existing models already setup in the radio without changes.
List of changes:
NEXT STEPS: work more on the scoring code.