-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create edge-monitor-server and test info/login endpoints #2
Conversation
paullinator
commented
Nov 20, 2023
•
edited
Loading
edited
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205147741891868
99cdc37
to
6296fec
Compare
message: string | ||
} | ||
|
||
export const statusCodes: { [key: string]: StatusCode } = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure is very login-server specific. I wouldn't replicate it on any other servers - we are only doing things this way because we have to remain compatible with the old Python code.
For instance, using integers for the status codes is pretty weird. We should use string enums, since those are easier to understand and read. Also, mixing the HTTP status code with the Edge status code leads to lots of weirdness.
I suggest just deleting the statusResponse
function and it's matching statusCodes
structure. This repo doesn't really use it in many places. You can hard-code { httpStatus: 404 }
in the missingRoute
function, and there should be no obsoleteRoute
, since this is a brand-new server.
For the health-check route and dummy route, maybe define a simple successResponse
function that returns { httpStatus: 200 }
.
6296fec
to
8512b5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the $default-branch syntax error and the archive start date.
8512b5b
to
f66d234
Compare
Used edge-login-server as a template to create edge-dummy-server. Used edge-dummy-server as template for this repo
f66d234
to
326be2f
Compare
Adds ability to test arbitrary GET/POST calls with url settings entirely configured on the DB.
Each fixture doc can specify the frequency that it is run in the engine loop
326be2f
to
ca58bdc
Compare