Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat '.' as zero #22

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Treat '.' as zero #22

merged 1 commit into from
Jul 16, 2024

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Jul 16, 2024


@peachbits peachbits merged commit 0d3706f into master Jul 16, 2024
1 of 3 checks passed
@peachbits peachbits deleted the only-decimal-point branch July 16, 2024 23:28
@samholmes
Copy link
Contributor

Approved with apprehension. I think biggystring should be moving towards stricter coercions for strings that aren’t necessarily valid numbers and the fixes to be applied at the call site. Things blowing up is better then unexpected number values silently making their way through algorithms. But, this is the way biggystring behaved before, so we must break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants