Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODS-5992] Github build warnings fix #847

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[ODS-5992] Github build warnings fix #847

merged 1 commit into from
Oct 10, 2023

Conversation

semalaiappan
Copy link
Contributor

No description provided.

@semalaiappan semalaiappan requested a review from a team as a code owner October 10, 2023 16:59
@@ -24,17 +24,17 @@ jobs:
ExtensionVersions: ${{ steps.Set_ExtensionVersions.outputs.ExtensionVersions }}
steps:
- name: Checkout Ed-Fi-Extensions
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # v2
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to update https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-Actions/blob/main/action-allowedlist/approved.json as well. When you do so, please mark all checkout v3 instances as deprecated (see line 6 for example).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure . Thank you

@stephenfuqua stephenfuqua merged commit 7450775 into main Oct 10, 2023
40 checks passed
@stephenfuqua stephenfuqua deleted the ODS-5992 branch October 10, 2023 20:29
@semalaiappan semalaiappan restored the ODS-5992 branch October 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants