[ODS-6540] Fix TreatErrorsAsWarning typo (#1173)

Ed-Fi-Alliance-OSS · Oct 30, 2024 · 6ed0b28 · 6ed0b28
1 parent 8755adb
commit 6ed0b28
Show file tree

Hide file tree

Showing 18 changed files with 26 additions and 20 deletions.
diff --git a/Application/EdFi.Ods.Api/EdFi.Ods.Api.csproj b/Application/EdFi.Ods.Api/EdFi.Ods.Api.csproj
@@ -6,7 +6,7 @@
     <AssemblyName>EdFi.Ods.Api</AssemblyName>
     <AssemblyVersion>99.99.99.00</AssemblyVersion>
     <RootNamespace>EdFi.Ods.Api</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <PackageProjectUrl>https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-ODS</PackageProjectUrl>

diff --git a/...tion/EdFi.Ods.Repositories.NHibernate.Tests/EdFi.Ods.Repositories.NHibernate.Tests.csproj b/...tion/EdFi.Ods.Repositories.NHibernate.Tests/EdFi.Ods.Repositories.NHibernate.Tests.csproj
@@ -6,7 +6,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemlbyName>EdFi.Ods.Repositories.NHibernate.Tests</AssemlbyName>
     <RootNamespace>EdFi.Ods.Repositories.NHibernate.Tests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/Application/EdFi.Ods.Tests.TestExtension/EdFi.Ods.Tests.TestExtension.csproj b/Application/EdFi.Ods.Tests.TestExtension/EdFi.Ods.Tests.TestExtension.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>EdFi.Ods.Tests.FakeExtension</AssemblyName>
     <RootNamespace>EdFi.Ods.Tests.FakeExtension</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
   </PropertyGroup>

diff --git a/....Ods.Tests/EdFi.Ods.Common/Database/Querying/IdentificationCodeCriteriaApplicatorTests.cs b/....Ods.Tests/EdFi.Ods.Common/Database/Querying/IdentificationCodeCriteriaApplicatorTests.cs
@@ -29,7 +29,6 @@ public class IdentificationCodeAggregateRootQueryCriteriaApplicatorTests
     {
         private IResourceModel _resourceModel;
         private IResourceModelProvider _resourceModelProvider;
-        private IResourceIdentificationCodePropertiesProvider _resourceIdentificationCodePropertiesProvider;
         private readonly string identificationCodeTableAlias =
             IdentificationCodeAggregateRootQueryCriteriaApplicator.IdentificationCodeEntityTableAlias();
 

diff --git a/...ds.Tests/EdFi.Ods.Features/OpenApiMetadata/Providers/OpenApiMetadataCacheProviderTests.cs b/...ds.Tests/EdFi.Ods.Features/OpenApiMetadata/Providers/OpenApiMetadataCacheProviderTests.cs
@@ -748,7 +748,6 @@ public void Should_be_a_valid_swagger_document_for_each_extension_schema_in_the_
         public class When_requesting_a_section_from_the_cache_for_which_no_route_was_registered : TestFixtureBase
         {
             private OpenApiMetadataCacheProvider _openApiMetadataCacheProvider;
-            private IResourceIdentificationCodePropertiesProvider _resourceIdentificationCodePropertiesProvider;
             private List<OpenApiContent> _actualMetadata;
 
             protected override void Arrange()

diff --git a/...Fi.Ods.Tests/EdFi.Ods.Security/Authorization/EntityAuthorization/EntityAuthorizerTests.cs b/...Fi.Ods.Tests/EdFi.Ods.Security/Authorization/EntityAuthorization/EntityAuthorizerTests.cs
@@ -115,7 +115,7 @@ public async Task AuthorizeEntityAsync_ShouldCallValidateOnAuthorizationValidato
     }
 
     [Test]
-    public async Task AuthorizeEntityAsync_ShouldThrowException_WhenDelegateFilterAuthorizerFailsAndResults()
+    public Task AuthorizeEntityAsync_ShouldThrowException_WhenDelegateFilterAuthorizerFailsAndResults()
     {
         // Arrange
         var actionUri = "some-action-uri";
@@ -150,6 +150,8 @@ public async Task AuthorizeEntityAsync_ShouldThrowException_WhenDelegateFilterAu
             _entityAuthorizer.AuthorizeEntityAsync(entity, actionUri, AuthorizationPhase.ExistingData, CancellationToken.None));
 
         ex.Message.ShouldBe("Authorization failed");
+
+        return Task.CompletedTask;
     }
 
     [Test]
@@ -295,7 +297,7 @@ public async Task AuthorizeEntityAsync_ShouldPerformViewBasedAuthorization_WhenP
     }
 
     [Test]
-    public async Task AuthorizeEntityAsync_ShouldThrow_WhenAllPendingExistenceChecksIsEmpty()
+    public Task AuthorizeEntityAsync_ShouldThrow_WhenAllPendingExistenceChecksIsEmpty()
     {
         // Arrange
         var actionUri = "some-action-uri";
@@ -332,10 +334,12 @@ public async Task AuthorizeEntityAsync_ShouldThrow_WhenAllPendingExistenceChecks
             _entityAuthorizer.AuthorizeEntityAsync(entity, actionUri, AuthorizationPhase.ExistingData, CancellationToken.None));
 
         ex.Message.ShouldBe("Authorization failed");
+
+        return Task.CompletedTask;
     }
 
     [Test]
-    public async Task AuthorizeEntityAsync_ShouldThrow_WhenPendingOrStrategyResultsInFailedState()
+    public Task AuthorizeEntityAsync_ShouldThrow_WhenPendingOrStrategyResultsInFailedState()
     {
         // Arrange
         var actionUri = "some-action-uri";
@@ -383,5 +387,7 @@ public async Task AuthorizeEntityAsync_ShouldThrow_WhenPendingOrStrategyResultsI
             _entityAuthorizer.AuthorizeEntityAsync(entity, actionUri, AuthorizationPhase.ExistingData, CancellationToken.None));
 
         ex.Message.ShouldBe("Authorization failed");
+
+        return Task.CompletedTask;
     }
 }
diff --git a/...ecurity/Authorization/EntityAuthorization/EntityInstanceViewBasedFilterAuthorizerTests.cs b/...ecurity/Authorization/EntityAuthorization/EntityInstanceViewBasedFilterAuthorizerTests.cs
@@ -37,7 +37,7 @@ public void SetUp()
     private EntityInstanceViewBasedFilterAuthorizer _authorizer;
 
     [Test]
-    public async Task PerformViewBasedAuthorizationAsync_ShouldNotExecuteQuery_WhenParameterValuesAreNull()
+    public Task PerformViewBasedAuthorizationAsync_ShouldNotExecuteQuery_WhenParameterValuesAreNull()
     {
         // Arrange
         var resultsWithPendingExistenceChecks = new[]
@@ -83,6 +83,8 @@ public async Task PerformViewBasedAuthorizationAsync_ShouldNotExecuteQuery_WhenP
                 resultsWithPendingExistenceChecks,
                 claimEducationOrganizationIds))
             .MustNotHaveHappened();
+
+        return Task.CompletedTask;
     }
 
     [Test]

diff --git a/Application/EdFi.Ods.Tests/EdFi.Ods.Tests.csproj b/Application/EdFi.Ods.Tests/EdFi.Ods.Tests.csproj
@@ -6,7 +6,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>EdFi.Ods.Tests</AssemblyName>
     <RootNamespace>EdFi.Ods.Tests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/Application/Test.Common/Test.Common.csproj b/Application/Test.Common/Test.Common.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>Test.Common</AssemblyName>
     <RootNamespace>Test.Common</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
   </PropertyGroup>

diff --git a/Utilities/GenerateSecurityGraphs/GenerateSecurityGraphs/GenerateSecurityGraphs.csproj b/Utilities/GenerateSecurityGraphs/GenerateSecurityGraphs/GenerateSecurityGraphs.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net8.0</TargetFramework>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
   </PropertyGroup>
   <ItemGroup>

diff --git a/tests/EdFi.Admin.DataAccess.IntegrationTests/EdFi.Admin.DataAccess.IntegrationTests.csproj b/tests/EdFi.Admin.DataAccess.IntegrationTests/EdFi.Admin.DataAccess.IntegrationTests.csproj
@@ -5,7 +5,7 @@
     <Product>EdFi.Admin.DataAccess.IntegrationTests</Product>
     <Assembly>EdFi.Admin.DataAccess.IntegrationTests</Assembly>
     <RootNameSpace>EdFi.Admin.DataAccess.IntegrationTests</RootNameSpace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>

diff --git a/tests/EdFi.Admin.DataAccess.UnitTests/EdFi.Admin.DataAccess.UnitTests.csproj b/tests/EdFi.Admin.DataAccess.UnitTests/EdFi.Admin.DataAccess.UnitTests.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>EdFi.Admin.DataAccess.UnitTests</AssemblyName>
     <RootNamespace>EdFi.Admin.DataAccess.UnitTests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.Ods.Api.IntegrationTests/EdFi.Ods.Api.IntegrationTests.csproj b/tests/EdFi.Ods.Api.IntegrationTests/EdFi.Ods.Api.IntegrationTests.csproj
@@ -6,7 +6,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>EdFi.Ods.Api.IntegrationTests</AssemblyName>
     <RootNamespace>EdFi.Ods.Api.IntegrationTests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.Ods.WebApi.CompositeSpecFlowTests/EdFi.Ods.WebApi.CompositeSpecFlowTests.csproj b/tests/EdFi.Ods.WebApi.CompositeSpecFlowTests/EdFi.Ods.WebApi.CompositeSpecFlowTests.csproj
@@ -5,7 +5,7 @@
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <RootNamespace>EdFi.Ods.WebApi.CompositeSpecFlowTests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.Ods.WebApi.IntegrationTests/EdFi.Ods.WebApi.IntegrationTests.csproj b/tests/EdFi.Ods.WebApi.IntegrationTests/EdFi.Ods.WebApi.IntegrationTests.csproj
@@ -6,7 +6,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>EdFi.Ods.WebApi.IntegrationTests</AssemblyName>
     <RootNamespace>EdFi.Ods.WebApi.IntegrationTests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/...dFi.Security.DataAccess.IntegrationTests/EdFi.Security.DataAccess.IntegrationTests.csproj b/...dFi.Security.DataAccess.IntegrationTests/EdFi.Security.DataAccess.IntegrationTests.csproj
@@ -6,7 +6,7 @@
     <Assembly>EdFi.Security.DataAccess.IntegrationTests</Assembly>
     <RootNameSpace>EdFi.Security.DataAccess.IntegrationTests</RootNameSpace>
     <Copyright>Copyright © 2024, Ed-Fi Alliance and contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>

diff --git a/tests/EdFi.Security.DataAccess.UnitTests/EdFi.Security.DataAccess.UnitTests.csproj b/tests/EdFi.Security.DataAccess.UnitTests/EdFi.Security.DataAccess.UnitTests.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <AssemblyName>EdFi.Security.DataAccess.UnitTests</AssemblyName>
     <RootNamespace>EdFi.Security.DataAccess.UnitTests</RootNamespace>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.TestFixture/EdFi.TestFixture.csproj b/tests/EdFi.TestFixture/EdFi.TestFixture.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <Configurations>Debug;Release</Configurations>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsPackable>false</IsPackable>