[DI-1132] Add Delete By Id Functionality #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simpat-adam
commented
Dec 2, 2023
•
simpat-adam
commented
- Adds Delete By Id functionality.
- Fixes integration tests using python.exe where the test would try to access the process after it had exited.
simpat-adam
force-pushed
the
DI-1132
branch
2 times, most recently
from
f376501 to
413eb2b
Compare
… after process has completed.
simpat-adam
force-pushed
the
DI-1132
branch
3 times, most recently
from
7cab65f to
0627319
Compare
CSR2017
reviewed
Dec 6, 2023
| var result = new JObject { new JProperty("Id", new JObject { new JProperty("Column", node.SourceColumn) }) }; | ||
| return result; | ||
| } | ||
|
|
||
| private JArray SerializeArray(ResourceMetadata arrayItemMetadata, IReadOnlyList<DataMapper> nodes) |
There was a problem hiding this comment.
@simpat-adam
Can we have separate DataMapSerializer class for just for Delete operations ? This will make sure to have single response across the classes. If we add delete by natural key we can plugin one more class or over loads on this class !
| @@ -170,7 +171,7 @@ protected override async Task Handle(Command request, CancellationToken cancella | |||
| } | |||
| } | |||
|
|
|||
| private async Task TransformAndPostEachRowUsingDataMap(File file, DataMap dataMap, IOdsApi odsApi, Agent agent) | |||
| private async Task TransformAndProcessEachRowUsingDataMap(File file, DataMap dataMap, IOdsApi odsApi, Agent agent) | |||
There was a problem hiding this comment.
Method renaming looks good 👍
CSR2017
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.