-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pielou's eveness, fix typo in documentation #45
Conversation
Oops, I started writing an example for the Metacommunity constructor, but I realized after making the PR that I didn't finish it. This is related to #43, but I currently don't understand the package well enough to finish the example. |
Thanks @PeetoomHeida! Could you reference Pielou's evenness in the docs, and ideally link to another implementation so I can check the code? |
I have grabbed the implementation from R vegan, and made a MWE here. I made the function for this package consistent with the others in there, where cols are sites are rows are spp, so be sure to make that switch in matrix structure when checking it in the Julia version. I also fixed the docstrings and added it to the ecology.md docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Sorry for the delay in spotting you'd made the changes. I've made some comments on your edits - I understand why you've switched rows and columns, but I think it just makes things more confusing given we always use them the other way round - in fact you confused yourself at one point! I'll probably have more to say after you've made these changes, but I'm onto it now. Apologies again for the delay.
Pull Request Test Coverage Report for Build 2213794478Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #45 +/- ##
==========================================
- Coverage 82.05% 80.78% -1.28%
==========================================
Files 15 15
Lines 613 666 +53
==========================================
+ Hits 503 538 +35
- Misses 110 128 +18
Continue to review full report at Codecov.
|
It looks like a bunch of files that I didn't mean to stage commits to got mixed into the PR. I'll sort this out and take a look at the row/column issues as well. |
Fixed wording in ecology.md Co-authored-by: Richard Reeve <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the issues.
Great. However, before I review it you need to restore |
Oh man, thanks for your patience as I get better at making PRs. Hopefully everything is good now, and hopefully the next PR goes smoother! The |
#44 addressed, fixed a typo in the documentation