Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace C# Godot's dependencies with muhammad-sammy.csharp #582

Merged
merged 4 commits into from
Apr 29, 2022

Conversation

manuth
Copy link
Contributor

@manuth manuth commented Apr 26, 2022

Description

In a workaround I've created a short time ago, I added the neikeq.godot-csharp-vscode extension.
However, this extension couldn't be published as it depends on extensions which aren't available in the open-vsx store.

Thus, changes made in this PR will change the dependencies to their corresponding open source variants.
In doing so, changes made in this PR will fix the publishing process of the neikeq.godot-csharp-vscode extension.

@manuth
Copy link
Contributor Author

manuth commented Apr 26, 2022

@filiptronicek I'm done 😄
Thanks a lot for your patience!

extensions.json Outdated Show resolved Hide resolved
@manuth manuth requested a review from filiptronicek April 29, 2022 06:07
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@filiptronicek filiptronicek merged commit 54cbb98 into EclipseFdn:master Apr 29, 2022
@filiptronicek
Copy link
Member

@manuth 🎉 https://open-vsx.org/extension/neikeq/godot-csharp-vscode

@manuth
Copy link
Contributor Author

manuth commented Apr 29, 2022

@manuth 🎉 https://open-vsx.org/extension/neikeq/godot-csharp-vscode

Awesome! Thank you so much for letting me know 😄
I'm literally partying rn 😂

I'll open up a new PR changing all sed-commands to jq as soon as I've got some time left for it!
Thanks for the effort!

@filiptronicek
Copy link
Member

I'll open up a new PR changing all sed-commands to jq as soon as I've got some time left for it!

Maybe it would be a nice change, I didn't know previously you could do JSON-writing with jq, so it could be really here.

I'm literally partying rn 😂

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants