adding kdcro101.favorites

[GitMensch]

• I have read the note above about PRs contributing or fixing extensions
• I have tried reaching out to the extension maintainers about publishing this extension to OpenVSX: FR: please co-publish on Open VSX Registry kdcro101/vscode-favorites#52
• This extension has an OSI-approved OSS license: MIT

Description

This PR introduces adds kdcro101.favorites which is currently missing and quite useful.

[GitMensch]

Whatever that validation CI wants to tell me...

[filiptronicek]

Hi @GitMensch 👋, because the repo seems inactive since 2018, I will try to build the extension manually and publish it manually as well, so it is not present in the repo when it is not receiving any further updates.

[filiptronicek]

Having issues with typescript type checking, @GitMensch were you able to build the extension locally?

[GitMensch]

I haven't built that in the since years.

So the point is: not adding it in the CI worker but publish once manually, correct?
Would it be reasonable in that case to use the old vsix that was published to the MS store?

[filiptronicek]

@GitMensch yes, we would publish once manually via a built vsix file. We don't want to use vsix files downloaded from MS as it may violate their ToS.

[GitMensch]

@filiptronicek The repo got an update and I hope it will do so further - but there is zero response to the Open-VSX publishing, so I suggest to either publish it once now - as you've noted above - or add to CI.

[GitMensch]

ping @filiptronicek: as it should build now can you please either approve/pull the ci change or manually push the vsix?

[filiptronicek]

Sorry for the delay here, @GitMensch, I have tried re-building but again it's the same issue with tsc complaining a bunch 😢.

[filiptronicek]

If you can build it, can you send over the instructions to build it even once so that we can publish that? I'd love if we could have the extension on Open VSX.