Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MyST-Markdown #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add MyST-Markdown #533

wants to merge 1 commit into from

Conversation

rtbs-dev
Copy link

@rtbs-dev rtbs-dev commented Jan 12, 2022

Based on discussion here

@rtbs-dev rtbs-dev changed the title add myst-vs-code entry to extensions.js Add MyST-Markdown Jan 12, 2022
@rtbs-dev
Copy link
Author

Based on the link above, the maintainer of MyST-Markdown was seeking support/PR's to publish on Open-VSX.

@chrisjsewell This PR would add MyST-Markdown to open-vsx, resolving Issue#33. I think the devs here generally prefer the maintainers add their own extensions directly, but if you are ok with this it should work fine.

@chrisjsewell
Copy link

Fine by me thanks 👍

@rtbs-dev
Copy link
Author

Fine by me thanks +1

Cool. For the future, if you want to manage both publishing to Marketplace and Open-vsx on the same toolchain, see this from another group asking to add to open-vsx. They link a github action they use to do both when a tag is published, which might be nicer.

@filiptronicek
Copy link
Member

Hey there @tbsexton & @chrisjsewell, I'm happy that you want to add the extension to OpenVSX. In this repo, we try to minimize the number of extensions (we have 400+ currently) so that the jobs are quicker, it's easier to maintain and the extension authors know right away when something goes wrong.

The setup is pretty easy with GitHub Actions, so if someone wants to try implementing it, you can follow this guide with this template (both still a bit WIP) and ping me if there are any difficulties. If necessary, I can also contribute the PR myself, I'd be delighted to help 🙂.

@filiptronicek filiptronicek self-assigned this Jan 12, 2022
@akosyakov
Copy link
Collaborator

@filiptronicek looks like PR is welcomed: executablebooks/myst-vs-code#33 (comment)

@filiptronicek filiptronicek added the extension Regarding an extension label Jan 17, 2022
@rtbs-dev
Copy link
Author

@filiptronicek if you start a PR to address executablebooks/myst-vs-code#33, I can see if I can help fill in some blanks.

@filiptronicek
Copy link
Member

@filiptronicek if you start a PR to address executablebooks/myst-vs-code#33, I can see if I can help fill in some blanks.

Just raised executablebooks/myst-vs-code#37

@filiptronicek filiptronicek added the changes-requested Waiting for an update label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Waiting for an update extension Regarding an extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants