Check whether extension has an OSI approved license #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Nov 26, 2021
lib/resolveExtension.js
Outdated
| @@ -53,6 +54,26 @@ exports.resolveExtension = async function ({ id, repository, location }, ms) { | |||
| await exec(`git clone --filter=blob:none --recurse-submodules ${repository} ${repoPath}`, { quiet: true }); | |||
|
|
|||
| const packagePath = [repoPath, location, 'package.json'].filter(p => !!p).join('/'); | |||
|
|
|||
| //#region Check if the extension has an OSI-approved open-source license | |||
| try { | |||
There was a problem hiding this comment.
Should not we check a revision form which we build vsix file?
There was a problem hiding this comment.
Great catch, @akosyakov, I was thinking about doing that, settled on "licenses don't change from commit to commit, right?". In edge cases where a license might be changed, added, or removed, I'll integrate it into the resolveVersion function to avoid otherwise duplicating the code over and over.
There was a problem hiding this comment.
Just looked into this again, and it seems there is no way to fetch the license for a specific time in the repository, just the current state. I checked with both the REST and GraphQL APIs, the only parameters allowed are name and owner.
akosyakov
force-pushed
the
master
branch
2 times, most recently
from
da64976 to
2baee1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510
How to test
extensions.jsonGITHUB_TOKEN, so that the script can request the GitHub API for the license)ToDo