Project Restructuring + Prod Dockerfile #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject's root instead of the cmd directory.
… the nodes. Updated Dockerfile.dev build path. Updated Dockerfile.prod to produce a final alpine image instead of using homebrew.
Closed
… job in the releast.yml workflow that publishes docker images to DockerHub and Container Registry
…ain directory in .goreleaser.yml config file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 79.66% 79.75% +0.09%
==========================================
Files 50 50
Lines 8794 8794
==========================================
+ Hits 7006 7014 +8
+ Misses 1277 1271 -6
+ Partials 511 509 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
main.gofile from thecmdsubfolder to the root folder.Dockerfile.prodfrom using homebrew to building from source.volumesfolder into theinternalfolder. Due to the example module go files, this folder was being picked up in thepkg.go.devlisting. This change should rectify that.release.ymlworkflow to build and publish docker images to DockerHub and Container Registry.Dockerfile changes address this issue and were inspired by this article.