Fixed cluster discovery logic and cofiguration #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly assigned on startup instead of configured manually. Replaced memberlist-port configuration with discovery-port.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 80.45% 80.32% -0.13%
==========================================
Files 48 48
Lines 8048 8057 +9
==========================================
- Hits 6475 6472 -3
- Misses 1102 1114 +12
Partials 471 471 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--memberlist-portconfiguration option renamed to--discovery-port.RaftBindPortconfiguration option. Raft bind address and port are now dynamically determined at runtime. When a new node joins a cluster it will advertise its raft address and port to its peers.