Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed --in-memory config flag. #51

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

kelvinmwinuka
Copy link
Collaborator

InMemory is now inferred from whether the data directory was provided.

@kelvinmwinuka kelvinmwinuka self-assigned this Jun 13, 2024
…ault test file. This parameter is now an empty string in order to force in-memory stores for raft store.
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (088900c) to head (df2b481).

Files Patch % Lines
internal/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files          48       48           
  Lines        8040     8037    -3     
=======================================
- Hits         6466     6464    -2     
+ Misses       1105     1102    -3     
- Partials      469      471    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelvinmwinuka kelvinmwinuka merged commit 1796004 into main Jun 13, 2024
2 of 3 checks passed
@kelvinmwinuka kelvinmwinuka deleted the fix/remove-in-memory-config branch June 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant