Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to EchoVault #45

Merged
merged 27 commits into from
Jun 2, 2024
Merged

Add test coverage to EchoVault #45

merged 27 commits into from
Jun 2, 2024

Conversation

kelvinmwinuka
Copy link
Collaborator

No description provided.

@kelvinmwinuka kelvinmwinuka self-assigned this May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 77.29730% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 79.51%. Comparing base (06ce6bf) to head (66b2842).
Report is 3 commits behind head on main.

Files Patch % Lines
echovault/echovault.go 56.41% 15 Missing and 2 partials ⚠️
internal/modules/acl/acl.go 78.33% 8 Missing and 5 partials ⚠️
internal/modules/acl/commands.go 91.07% 1 Missing and 4 partials ⚠️
internal/modules/acl/user.go 70.58% 5 Missing ⚠️
echovault/modules.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   76.83%   79.51%   +2.67%     
==========================================
  Files          48       48              
  Lines        7987     8040      +53     
==========================================
+ Hits         6137     6393     +256     
+ Misses       1395     1185     -210     
- Partials      455      462       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…other test results. ForwardCommand test now retries until all values are found in a quorum or a 5 second limit is reached.
…write-lock is acquired before modifying the connection object as well in addition to the users list.
…ests. This is to ensure the leader node is shutdown last.
@kelvinmwinuka kelvinmwinuka merged commit 66ac3b2 into main Jun 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant