Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for data replication layer #43

Merged
merged 13 commits into from
May 27, 2024

Conversation

kelvinmwinuka
Copy link
Collaborator

This change adds test cases for the raft and memberlist data replication logic.

@kelvinmwinuka kelvinmwinuka self-assigned this May 22, 2024
…ed lock-per-key for a store-wide rwmutex. Updated HandlerFuncParams to match new keyspace method signatures.
…ts tests to use resp connection instead of calling handler directly
… HSET and SINTERCARD to match new key overwriting behaviour.
Return "empty command" error from handleCommand method if an empty command is passed to the server.
Wait until connection is no longer nil in acl package tests.
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 75.73840% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 75.76%. Comparing base (7e585dc) to head (0108444).

Files Patch % Lines
echovault/keyspace.go 50.44% 52 Missing and 4 partials ⚠️
internal/modules/list/commands.go 78.57% 0 Missing and 12 partials ⚠️
internal/modules/sorted_set/commands.go 89.58% 0 Missing and 10 partials ⚠️
echovault/echovault.go 50.00% 8 Missing and 1 partial ⚠️
internal/modules/set/commands.go 86.15% 0 Missing and 9 partials ⚠️
internal/modules/hash/commands.go 82.50% 0 Missing and 7 partials ⚠️
internal/modules/generic/commands.go 86.84% 1 Missing and 4 partials ⚠️
internal/modules/string/commands.go 75.00% 0 Missing and 3 partials ⚠️
echovault/modules.go 83.33% 1 Missing and 1 partial ⚠️
echovault/test_helpers.go 66.66% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   74.76%   75.76%   +1.00%     
==========================================
  Files          46       46              
  Lines        8210     7796     -414     
==========================================
- Hits         6138     5907     -231     
+ Misses       1623     1467     -156     
+ Partials      449      422      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelvinmwinuka kelvinmwinuka merged commit 8f249d7 into main May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant