Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extension of EchoVault commands using the embedded API #33

Merged
merged 10 commits into from
Apr 29, 2024
Merged

Allow extension of EchoVault commands using the embedded API #33

merged 10 commits into from
Apr 29, 2024

Conversation

kelvinmwinuka
Copy link
Collaborator

This change introduces 3 methods in the embedded API to extend the commands in the EchoVault server.

  1. AddCommand allows the user to add new commands and subcommand to EchoVault.
  2. ExecuteCommand allows the user to dynamically execute a commands that is not exposed by the embedded API (eg. Dynamically loaded commands)
  3. RemoveCommands allows the user to remove commands and subcommand from the EchoVault instance.

@kelvinmwinuka
Implemented ADD_COMMAND method to add a custom command to echovault
2291ba4
@kelvinmwinuka
Created EXECUTE_COMMAND method that allows raw execution of loaded co…
b6825c4 
…mmands when in embedded mode
@kelvinmwinuka
Moved all packages from /pkg directory to the root directory. Deleted…
97f4617 
… /pkg directory. Pass keyspace functions to raft package instead of an EchoVault instance. This removes dependency on the echovault pakage from the raft package.
@kelvinmwinuka
Added REMOVE_COMMAND method for removing commands or subcommands
54bed13
@kelvinmwinuka
Enable adding command with subcommands in ADD_COMMAND method
8baeaa9
@kelvinmwinuka
Renamed command API methods to use CamelCase
972cbe0
@kelvinmwinuka
Renamed *AccessKey type to better represent the response on *KeyExtra…
c241cc0 
…ctionFunc types
@kelvinmwinuka
Implemented tests for AddCommand, ExecuteCommand and RemoveCommand me…
1d56e98 
…thods
@kelvinmwinuka
Added condition to skip duplicate subcommands when adding a new comma…
dcb88ff 
…nd with subcommands
@kelvinmwinuka
Added godoc commends for embedded methods and types to extend command…
281c4f2 
…s. Moved constants to internal directory
@kelvinmwinuka kelvinmwinuka self-assigned this Apr 29, 2024
@kelvinmwinuka kelvinmwinuka linked an issue Apr 29, 2024 that may be closed by this pull request
Extend EchoVault commands with embedded API #31
Closed
@kelvinmwinuka kelvinmwinuka merged commit f017d65 into main Apr 29, 2024
1 check passed
@kelvinmwinuka kelvinmwinuka deleted the feature/embedded-extensions branch June 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kelvinmwinuka kelvinmwinuka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend EchoVault commands with embedded API
1 participant
@kelvinmwinuka