Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a Clock interface that is used instead of time.Now to aid testing #20

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

kelvinmwinuka
Copy link
Collaborator

…d time.After are used.

@kelvinmwinuka kelvinmwinuka self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.81%. Comparing base (6e51097) to head (25ffb30).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/echovault/keyspace.go 0.00% 1 Missing and 1 partial ⚠️
pkg/echovault/echovault.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   59.76%   59.81%   +0.04%     
==========================================
  Files          31       31              
  Lines        5831     5838       +7     
==========================================
+ Hits         3485     3492       +7     
  Misses       2046     2046              
  Partials      300      300              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelvinmwinuka kelvinmwinuka merged commit 4fff666 into main Apr 4, 2024
3 checks passed
@kelvinmwinuka kelvinmwinuka deleted the enhancement/time-abstraction branch June 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant