Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on my old crappy macbook and ran into some issues related to docker-compose and my os just being kinda old. To get around this I repurposed the windows_test_env to be more flexible. It's been renamed to
test_env
and has the following -make testenv-all
runs bothtest
andtest-race
sequentially like the original dockerfile did before.make testenv-test
runsmake test
only.make testenv-test-race
runsmake test-race
only.make testenv-run
builds and runs a docker container in interactive mode. This allows for easier debugging of a single test or group of tests as well as allows easy execution other commands/scripts likemake benchmark
. This container will not update the projects coverage.out.