Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/module tests #13

Merged
merged 12 commits into from
Mar 24, 2024
Merged

Chore/module tests #13

merged 12 commits into from
Mar 24, 2024

Conversation

kelvinmwinuka
Copy link
Collaborator

Changes:

  1. Fixed Pub/Sub bug where sometimes channel subscribers would hang, causing them not to receive the messages they have subscribed to
  2. Removed consumer groups from Pub/Sub implementation for closer compatibility with the Redis client.
  3. Fixed race condition when updating, loading, or saving ACL.

@kelvinmwinuka
Created init function for acl module test suite
0e5f8ff
@kelvinmwinuka
Implemented test for AUTH command handler
9191d16
@kelvinmwinuka
Initialise default IncludedCategories to allCategories("*").
018aea7 
Implemented test for ACL USERS command.
@kelvinmwinuka
Created compareSlices and compareUsers functions as helpers for compa…
f4d4271 
…ring slices and users in tests. Implemented tests for creating enabled and disabled users with ACL SETUSER command
@kelvinmwinuka
Implemented tests for ACL SETUSER command handler
5bb2bd1
@kelvinmwinuka
Implemented test for ACL GETUSER command
1cca650
@kelvinmwinuka
Implemented RWMutex for users list when handling user mutations and a…
d51dfd5 
…uth. Fixed bug where user delete command would delete all the users except the specified one. Implemented test for ACL DELUSER command
@kelvinmwinuka
Implemented test for ACL WHOAMI command handler
a48b98a
@kelvinmwinuka
Implemented test for ACL LIST command handler
78225cd
@kelvinmwinuka
Add coverage file to tracked files
2a7d472
@kelvinmwinuka
Implemented locking mechanism for ACL LOAD and ACL SAVE commands
0cd8a4a
@kelvinmwinuka kelvinmwinuka added enhancement New feature or request testing Testing task labels Mar 24, 2024
@kelvinmwinuka kelvinmwinuka self-assigned this Mar 24, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 24, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@kelvinmwinuka kelvinmwinuka merged commit b4188a2 into main Mar 24, 2024
3 checks passed
@kelvinmwinuka kelvinmwinuka deleted the chore/module-tests branch June 15, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kelvinmwinuka kelvinmwinuka

Labels
enhancement New feature or request testing Testing task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kelvinmwinuka