Update Hash to allow for expirey commands (#146)

* Convert hash to composite type. Fixed broken Hash commands from Hash refactor. Coverage and fixed broken test - @osteensco
EchoVault · Nov 3, 2024 · 0964008 · 0964008
1 parent 05b7601
commit 0964008
Show file tree

Hide file tree

Showing 8 changed files with 5,189 additions and 5,129 deletions.
diff --git a/coverage/coverage.out b/coverage/coverage.out
diff --git a/internal/modules/generic/commands.go b/internal/modules/generic/commands.go
@@ -813,7 +813,11 @@ func handleType(params internal.HandlerFuncParams) ([]byte, error) {
 	case reflect.Slice:
 		type_string = "list"
 	case reflect.Map:
-		type_string = "hash"
+		if t.Elem().Name() == "HashValue" {
+			type_string = "hash"
+		} else {
+			type_string = t.Elem().Name()
+		}
 	case reflect.Pointer:
 		if t.Elem().Name() == "Set" {
 			type_string = "set"

diff --git a/internal/modules/generic/commands_test.go b/internal/modules/generic/commands_test.go
@@ -2786,7 +2786,7 @@ func Test_Generic(t *testing.T) {
 		}()
 		client := resp.NewConn(conn)
 
-		expected := "Key"
+		expected := "key"
 		if err = client.WriteArray([]resp.Value{resp.StringValue("RANDOMKEY")}); err != nil {
 			t.Error(err)
 		}
@@ -2796,7 +2796,7 @@ func Test_Generic(t *testing.T) {
 			t.Error(err)
 		}
 
-		if !strings.Contains(res.String(), expected) {
+		if !strings.Contains(strings.ToLower(res.String()), expected) {
 			t.Errorf("expected a key containing substring '%s', got %s", expected, res.String())
 		}
 	})