Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyArrayAsDefaultConverter: treat empty object {} as default (null) #309

Merged
merged 3 commits into from
Jan 15, 2024
Merged

EmptyArrayAsDefaultConverter: treat empty object {} as default (null) #309

merged 3 commits into from
Jan 15, 2024

Conversation

inikulshin
Copy link
Contributor

@inikulshin inikulshin commented Jan 14, 2024 •
edited
Loading

@inikulshin inikulshin mentioned this pull request Jan 14, 2024
Closed
@inikulshin
Copy link
Contributor Author

Please, upload new NuGet package after PR completion.

@zidad
Copy link
Member

zidad commented Jan 15, 2024

Can you add some test coverage for these scenario's as well?

@inikulshin
Copy link
Contributor Author

Can you add some test coverage for these scenario's as well?

I can add serialization tests only. Don't have deterministic reproduction scenario against RabbitMQ.

@zidad zidad merged commit ee43f14 into EasyNetQ:master Jan 15, 2024
6 checks passed
@inikulshin inikulshin mentioned this pull request Jan 15, 2024
Closed
@inikulshin inikulshin deleted the EmptyArrayAsDefaultConverter branch January 21, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zidad zidad zidad approved these changes

@Pliner Pliner Awaiting requested review from Pliner Pliner is a code owner

@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner

@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inikulshin @zidad