Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IManagementClient.GetShovelStatusesAsync() (api/shovels) #295

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Add IManagementClient.GetShovelStatusesAsync() (api/shovels) #295

merged 3 commits into from
Jan 3, 2024

Conversation

inikulshin
Copy link
Contributor

No description provided.

Pliner
Pliner reviewed Dec 25, 2023
View reviewed changes
Source/EasyNetQ.Management.Client/Serialization/DateTimeConverter.cs
{
public override DateTime Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
Debug.Assert(typeToConvert == typeof(DateTime));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if we make ShovelStatus.Timestamp string rather than DateTime.

@inikulshin
Copy link
Contributor Author

inikulshin commented Dec 25, 2023 •
edited
Loading

@Pliner what about the GetShovelStatuses name?

I thought that GetShovels (corresponding to /api/shovels/) will be confusing.
We have CreateShovel/DeleteShovel extensions of CreateParameter/DeleteParameter, so GetShovels is supposed to be extension of GetParameters.

I took ShovelStatus from https://www.rabbitmq.com/shovel-dynamic.html#status and used plural form Statuses because probably there will be a GetShovelStatus, returning single record.

@inikulshin
Copy link
Contributor Author

@Pliner can you approve, please?
We need this change to finally move to latest EasyNetQ version from our custom build.

@zidad zidad merged commit 9284cbb into EasyNetQ:master Jan 3, 2024
6 checks passed
@inikulshin inikulshin deleted the GetShovels branch January 3, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pliner Pliner Pliner left review comments

@zidad zidad zidad approved these changes

@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner

@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inikulshin @zidad @Pliner