-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PolicyDefinition.ExtensionData, Queue.ExtensionData, IMC.GetQueuesWithoutStatsAsync #285
Conversation
@Pliner @zidad @micdenny @luigiberrettini please, review and comment. |
@inikulshin many thanks for this! What is the reason for adding the sync methods, do you really need them in your projects and why? Personally I would prefer to remove or obsolete all synchronous operations to simplify and clean the code base. |
I don't really need those few sync extensions I added, but I think that sync extensions must be either for all async API or for none (as you suggested). Sync extensions still don't cover all async API because I think that it should be a different PR. Personally I prefer to use those sync extensions and avoid P.S. Those extensions can be put in different extension package. |
I agree... It's fine for now but I think there's almost no valid use cases anymore to use sync versions of methods in applications, at least I haven't encountered any in the recent years.
It's unnecessarily verbose I agree but that just seems to be the standard way of calling pretty much every .net method nowadays :/
But what would be a use case where this is necessary? Not sure if "I just don't like to write await" is a strong enough reason to create a separate package for this :) |
Support custom policy definitions in GET and PUT.
Support unmapped queue stats.
Add IManagementClient.GetQueuesWithoutStatsAsync
http://localhost:15672/api/index.html
I expect more comments this time :)
I don't commit
approved.txt
until when.More changes can follow this PR, once approved.
Queue queue
parameter can be changed to receiveQueueName queueName
.GetAsync
?) should also have[JsonExtensionData()]
. But also in those that are used inPutAsync
andPostAsync
- to allow easy workaround for any missing or recently added property.GeneratePublicApi
forManagementClient
andManagementClientExtensions
, some simple string replaces and equality assertion.But let's discuss this one first.