Fixed bounds check of connectors when validating charging profile #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
4 tasks
Signed-off-by: Piet Gömpel <[email protected]>
hikinggrass
approved these changes
Jan 2, 2025
hikinggrass
reviewed
Jan 2, 2025
| @@ -166,7 +166,7 @@ bool SmartChargingHandler::validate_profile( | |||
| ChargingProfile& profile, const int connector_id, bool ignore_no_transaction, const int profile_max_stack_level, | |||
| const int max_charging_profiles_installed, const int charging_schedule_max_periods, | |||
| const std::vector<ChargingRateUnit>& charging_schedule_allowed_charging_rate_units) { | |||
| if ((size_t)connector_id > this->connectors.size() or connector_id < 0 or profile.stackLevel < 0 or | |||
| if ((size_t)connector_id >= this->connectors.size() or connector_id < 0 or profile.stackLevel < 0 or | |||
There was a problem hiding this comment.
In general we should probably use static_cast here instead of using a c-style cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review