Allow Answer NotSupported if the key customDisplayCostAndPrice is not present #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Suess <[email protected]>
Matthias-NIDEC
requested review from
Pietfried,
hikinggrass and
maaikez
as code owners
Matthias-NIDEC
changed the title
|
Hi @Matthias-NIDEC, #924 provides a solution that comes to the same result, but that is more in line wih how it is solved for other feature profiles / extensions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make customDisplayCostAndPrice an optional to allow answer NotSupported if not present.
Issue ticket number and link
Checklist before requesting a review