Make centralSystemURI accessible via changeConfiguration, reject if readOnly #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthias-NIDEC
requested review from
Pietfried,
hikinggrass and
maaikez
as code owners
…eadOnly Signed-off-by: Matthias Suess <[email protected]>
Pietfried
force-pushed
the
make_centralSystemURI_accessible_via_change_config
branch
from
33a1c54 to
c39f530
Compare
…RebootRequired if changed Signed-off-by: Piet Gömpel <[email protected]>
|
@hikinggrass please have a look since I pushed some small changes to this PR (added a log warning and responding with |
Pietfried
approved these changes
Dec 17, 2024
hikinggrass
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make centralSystemURI accessible via changeConfiguration.req, reject if readOnly
Issue ticket number and link
#901
Checklist before requesting a review