Integrate of send Triggermessage (MeterValues) in empty Connector case of present connectors or reject if non is present #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Handle the emptyConnector case for TriggerMessage of type meterValues.
Inside the OCPP 1.6 5.17. TriggerMessage:
"Inversely, if the connectorId is relevant but absent, this should be interpreted as “for all allowed connectorId
values”. For example, a request for a statusNotification for connectorId 0 is a request for the status of the
Charge Point. A request for a statusNotification without connectorId is a request for multiple statusNotifications:
the notification for the Charge Point itself and a notification for each of its connectors."
It is proposed to handle a TriggerMessage with requestedMessage MeterValues and empty ConnectorId the same, and send MeterValues.req for each connectorId having a MeterValue.
In the case, the connectorId is empty, it is checked if at least one connectorId is present and has a Metervalue to be send othwise, the answer to the TriggerMessage.req is 'Rejected'
"The Charge Point SHALL first send the TriggerMessage response, before sending the requested message. In the
TriggerMessage.conf the Charge Point SHALL indicate whether it will send it or not, by returning ACCEPTED or
REJECTED. It is up to the Charge Point if it accepts or rejects the request to send. If the requested message is
unknown or not implemented the Charge Point SHALL return NOT_IMPLEMENTED".
Option is to send "NOT_IMPLEMENTED".
Issue ticket number and link
#897
Checklist before requesting a review