Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate of send Triggermessage (MeterValues) in empty Connector case of present connectors or reject if non is present #898

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Matthias-NIDEC
Copy link
Contributor

@Matthias-NIDEC Matthias-NIDEC commented Dec 4, 2024

Describe your changes

Handle the emptyConnector case for TriggerMessage of type meterValues.

Inside the OCPP 1.6 5.17. TriggerMessage:

"Inversely, if the connectorId is relevant but absent, this should be interpreted as “for all allowed connectorId
values”. For example, a request for a statusNotification for connectorId 0 is a request for the status of the
Charge Point. A request for a statusNotification without connectorId is a request for multiple statusNotifications:
the notification for the Charge Point itself and a notification for each of its connectors."

It is proposed to handle a TriggerMessage with requestedMessage MeterValues and empty ConnectorId the same, and send MeterValues.req for each connectorId having a MeterValue.

In the case, the connectorId is empty, it is checked if at least one connectorId is present and has a Metervalue to be send othwise, the answer to the TriggerMessage.req is 'Rejected'

"The Charge Point SHALL first send the TriggerMessage response, before sending the requested message. In the
TriggerMessage.conf the Charge Point SHALL indicate whether it will send it or not, by returning ACCEPTED or
REJECTED. It is up to the Charge Point if it accepts or rejects the request to send. If the requested message is
unknown or not implemented the Charge Point SHALL return NOT_IMPLEMENTED".

Option is to send "NOT_IMPLEMENTED".

Issue ticket number and link

#897

Checklist before requesting a review

@Matthias-NIDEC Matthias-NIDEC changed the title Integrate of send of present connector or reject if non is present Integrate of send Triggermessage (MeterValues) in empty Connector case of present connectors or reject if non is present Dec 4, 2024
@Pietfried Pietfried self-assigned this Dec 11, 2024
@Pietfried Pietfried force-pushed the in_empty_connectorCase_on_triggerMessage_metervalues_send_for_all_present_meters branch from 6494a40 to 83e4139 Compare December 23, 2024 13:32
Signed-off-by: Piet Gömpel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On empty connector case for TriggerMessage.req for Metervalues, send Metervalues for present connector
3 participants