Number of fixes to the Metervalue implementation for 2.0.1 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcemmers
commented
Feb 5, 2024
marcemmers
commented
- Configurable rounding of clock aligned timestamps
- Filtering of tx ended meter values after the transaction has ended
- Correctly aligning the sampled data to the start of the transaction
- Clearing of accumulated metervalues before starting a transaction to clear out the idle metervalues
- Fix edge case where transaction start time is before an interval and code is run after an interval
Pietfried
reviewed
Feb 5, 2024
Pietfried
reviewed
Feb 5, 2024
Pietfried
approved these changes
Feb 14, 2024
| } | ||
| ], | ||
| "description": "If enabled the metervalues configured with the AlignedDataCtrlr will be rounded to the exact time intervals", | ||
| "default": "0", |
There was a problem hiding this comment.
Suggested change
| "default": "0", | |
| "default": true, |
I just noticed that this is an issue at several other places
There was a problem hiding this comment.
Yep that's what made me unsure if this was right. Shall I change those as well?
Also, I thought to leave it off by default or would you rather have it enabled?
There was a problem hiding this comment.
Yes, would be great if you can change all of them, thanks 👍 . Leave it off by default is fine for me
…s where applicable Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
… data: start from the transaction start date/time. Also include the clock aligned metervalue if it the timestamp is the same as the started timestamp Signed-off-by: Maaike Zijderveld, Alfen <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
marcemmers
force-pushed
the
me-clock-aligned-metervalues
branch
from
8ba99fd to
7653123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.