Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added features to EvseV2G doc.rst #964

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SebaLukas
Copy link
Contributor

@SebaLukas SebaLukas commented Nov 14, 2024

Describe your changes

Adding a features.md. This document contains two feature lists to show the current DIN70121 and ISO15118-2 support.

Issue ticket number and link

Without a feature list, it is quite difficult to get an overview of which DIN70121 and ISO15118-2 features EvseV2G already supports.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Copy link
Contributor

@barsnick barsnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. One typo though.
(Do also note the Codacy line length "issue".)

modules/EvseV2G/features.md Outdated Show resolved Hide resolved
@SebaLukas SebaLukas requested a review from barsnick December 9, 2024 11:18
@SebaLukas SebaLukas changed the title Added features.md in EvseV2G Added features to EvseV2G doc.rst Dec 9, 2024
modules/EvseV2G/doc.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@barsnick barsnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an RST parser. :D

Otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants