Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published Auth timeout for one additional flow #903

Merged

Conversation

ydankner
Copy link
Contributor

@ydankner ydankner commented Oct 10, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@ydankner ydankner marked this pull request as ready for review October 11, 2024 12:06
Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pietfried
Copy link
Contributor

Hi @ydankner , thanks for adding that. Please rebase so we can merge it.

@ydankner ydankner force-pushed the fix/auth_publishes_timeout_in_additional_flow branch from b06831c to 3255b63 Compare October 14, 2024 13:18
@ydankner
Copy link
Contributor Author

Hi @ydankner , thanks for adding that. Please rebase so we can merge it.

Rebased :) @Pietfried

@Pietfried
Copy link
Contributor

Hi @ydankner , thanks for adding that. Please rebase so we can merge it.

Rebased :) @Pietfried

Sorry, its again out-of-date, so please do another rebase

Yonatan Dankner added 4 commits October 14, 2024 17:20
Signed-off-by: Yonatan Dankner <[email protected]>
Signed-off-by: Yonatan Dankner <[email protected]>
@ydankner ydankner force-pushed the fix/auth_publishes_timeout_in_additional_flow branch from 3255b63 to 9e872e2 Compare October 14, 2024 15:20
@ydankner
Copy link
Contributor Author

Hi @ydankner , thanks for adding that. Please rebase so we can merge it.

Rebased :) @Pietfried

Sorry, its again out-of-date, so please do another rebase

Done!

@Pietfried Pietfried merged commit 544128e into EVerest:main Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants