-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPP: Handle ocpp::DateTime TimePointParseException #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hikinggrass
changed the title
WIP: handle new ocpp::DateTime TimePointParseException
OCPP: Handle ocpp::DateTime TimePointParseException
Oct 16, 2024
hikinggrass
requested review from
Pietfried,
maaikez and
corneliusclaussen
as code owners
October 16, 2024 10:32
Pietfried
approved these changes
Oct 16, 2024
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…erted Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
If this is not possible it will return the current DateTime Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
feature/handle-ocpp-datetime-exception
branch
from
October 16, 2024 13:00
ac2c919
to
9ef17fa
Compare
Pietfried
reviewed
Oct 16, 2024
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
added
the
include-in-release
Tag that this PR should be included in the current merge window for the upcoming release if possible
label
Oct 23, 2024
hikinggrass
added a commit
that referenced
this pull request
Oct 25, 2024
* Add warning when optional DisplayMessage timestamps could not be converted * Add function to convert a datetime string to OCPP DateTime If this is not possible it will return the current DateTime * Use to_ocpp_datetime_or_now for session event timestamps --------- Signed-off-by: Kai-Uwe Hermann <[email protected]> Signed-off-by: Piet Gömpel <[email protected]> Signed-off-by: Piet Gömpel <[email protected]> Co-authored-by: Piet Gömpel <[email protected]> Co-authored-by: Piet Gömpel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
include-in-release
Tag that this PR should be included in the current merge window for the upcoming release if possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review