Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPP: Handle ocpp::DateTime TimePointParseException #892

Merged
merged 16 commits into from
Oct 16, 2024

Conversation

hikinggrass
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@Pietfried Pietfried mentioned this pull request Oct 16, 2024
3 tasks
@hikinggrass hikinggrass changed the title WIP: handle new ocpp::DateTime TimePointParseException OCPP: Handle ocpp::DateTime TimePointParseException Oct 16, 2024
@hikinggrass hikinggrass marked this pull request as ready for review October 16, 2024 10:32
hikinggrass and others added 14 commits October 16, 2024 14:51
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
If this is not possible it will return the current DateTime

Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@Pietfried Pietfried force-pushed the feature/handle-ocpp-datetime-exception branch from ac2c919 to 9ef17fa Compare October 16, 2024 13:00
@hikinggrass hikinggrass merged commit 06038e4 into main Oct 16, 2024
10 checks passed
@hikinggrass hikinggrass deleted the feature/handle-ocpp-datetime-exception branch October 16, 2024 13:55
@hikinggrass hikinggrass added the include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible label Oct 23, 2024
hikinggrass added a commit that referenced this pull request Oct 25, 2024
* Add warning when optional DisplayMessage timestamps could not be converted
* Add function to convert a datetime string to OCPP DateTime

If this is not possible it will return the current DateTime

* Use to_ocpp_datetime_or_now for session event timestamps

---------

Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants