- Set state F for 300ms (configurable) after fault when in state C. #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
corneliusclaussen
force-pushed
the
bugfix/state-f-after-fault
branch
from
f0add43 to
c60183c
Compare
corneliusclaussen
added
the
include-in-release
corneliusclaussen
force-pushed
the
bugfix/state-f-after-fault
branch
from
c60183c to
7aef5b4
Compare
hikinggrass
approved these changes
Oct 1, 2024
- Set state F for 300ms (configurable) after fault when in state C. - Unlock connector in F after 5s to avoid lock/unlock in all temporary t_step_EFs Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/state-f-after-fault
branch
from
7aef5b4 to
d922801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review