Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docker images in EVerest #770

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Refactor docker images in EVerest #770

merged 9 commits into from
Aug 7, 2024

Conversation

andistorm
Copy link
Contributor

@andistorm andistorm commented Jul 9, 2024

Describe your changes

  • Add docker image ghcr.io/everest/everest-core/build-kit-everest-core
  • Refactor workflow build_and_test.yaml
    • Deploy docker image ghcr.io/everest/everest-core/build-kit-everest-core
    • Use deployed image as build kit image

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Requires

TODO before merging

  • Update everest-ci version to v1.3.1

Copy link
Contributor Author

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO before merge

.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
* Add docker image `ghcr.io/everest/everest-core/build-kit-everest-core`
* Refactor workflow `build_and_test.yaml`
  * Deploy docker image `ghcr.io/everest/everest-core/build-kit-everest-core`
  * Use deployed image as build kit image

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm andistorm force-pushed the refactor-docker-images branch from 317bf93 to 8d5d1ff Compare July 17, 2024 05:40
Copy link
Contributor Author

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update everest-ci version again

.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
@andistorm andistorm marked this pull request as ready for review July 29, 2024 11:36
@Pietfried Pietfried self-assigned this Jul 29, 2024
@andistorm andistorm merged commit 1460b53 into main Aug 7, 2024
10 of 11 checks passed
@andistorm andistorm deleted the refactor-docker-images branch August 7, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants