Feature/evsemanager ocpp errorhandling #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
added
the
post-release
Pietfried
force-pushed
the
feature/evsemanager-ocpp-errorhandling
branch
from
bbb3bf6 to
5ef39ba
Compare
Pietfried
force-pushed
the
feature/evsemanager-ocpp-errorhandling
branch
from
824bfe1 to
5ca8be5
Compare
corneliusclaussen
removed
the
post-release
Pietfried
force-pushed
the
feature/evsemanager-ocpp-errorhandling
branch
2 times, most recently
from
f85090f to
97b7a3e
Compare
4 tasks
Pietfried
reviewed
Jul 25, 2024
modules/OCPP/OCPP.cpp
Outdated
| const auto evse_id = error.origin.mapping.has_value() ? error.origin.mapping.value().evse : 0; | ||
|
|
||
| if (this->started) { | ||
| // TODO: Report correct evse_id once Error type includes it |
Pietfried
reviewed
Jul 25, 2024
modules/OCPP/OCPP.cpp
Outdated
| const auto evse_id = error.origin.mapping.has_value() ? error.origin.mapping.value().evse : 0; | ||
| const auto error_info = get_error_info(error); | ||
| if (this->started) { | ||
| // TODO: Report correct evse_id once Error type includes it |
Pietfried
reviewed
Jul 25, 2024
Pietfried
reviewed
Jul 25, 2024
Pietfried
force-pushed
the
feature/evsemanager-ocpp-errorhandling
branch
from
456f7d1 to
931ccbd
Compare
Pietfried
requested review from
hikinggrass,
maaikez and
SebaLukas
as code owners
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
…201 modules: * added enable_global_errors to OCPP and OCPP201 module to be able to subscribe to all errors reported in EVerest * added error_mapping.hpp to OCPP module to be able to convert to MREC errors * removed SessionEvent handling for ::Error and ::PermanentFault because this is replaced by subscribing to errors using the new tools of everest-framework Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: pietfried <[email protected]>
…error Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
…or. Added retrieval of evse id from error and use this for reporting. Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: pietfried <[email protected]>
…th module Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
feature/evsemanager-ocpp-errorhandling
branch
from
40bfcd1 to
6b80948
Compare
hikinggrass
requested changes
Jul 30, 2024
config/config-sil-ocpp-pnc.yaml
Outdated
| config_module: | ||
| connector_id: 1 | ||
| yeti_driver_2: | ||
| module: JsYetiSimulator | ||
| evse: 1 |
There was a problem hiding this comment.
That should be evse: 2 ?
dependencies.yaml
Outdated
| cmake_condition: "EVEREST_DEPENDENCY_ENABLED_LIBEVSE_SECURITY" | ||
|
|
||
| # OCPP | ||
| libocpp: | ||
| git: https://github.com/EVerest/libocpp.git | ||
| git_tag: 01f064f45f6d0ff44605db07373e4b9ea02b63b8 | ||
| git_tag: feature/refactor-ocpp16-error-state-machine |
There was a problem hiding this comment.
TODO: update before merge
Signed-off-by: pietfried <[email protected]>
Pietfried
reviewed
Jul 31, 2024
Signed-off-by: Piet Gömpel <[email protected]>
hikinggrass
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactored Error Handling in EvseManager
The following SessionEventEnums have been removed from the evse_manager interface:
The EvseManager now uses the error handling provided by the everest-framework to raise/report errors. A
PermanentFaulterror raised by the EvseManager indicates that charging is not possible.Refactored Error Handling in OCPP and OCPP201 modules
The OCPP modules where listening to the removed SessionEvents and were therefore refactored to be able to retrieve the errors raised by the new mechanism from the everest-framework.
Make use of everest-framework error handling feature in OCPP and OCPP201 modules:
Issue ticket number and link
Companion PR in libocpp: EVerest/libocpp#673
Checklist before requesting a review