Charger: Fix soft over current detection when PWM changes often #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
corneliusclaussen
added
the
include-in-release
hikinggrass
approved these changes
Jul 5, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/soft-over-current
branch
from
7d81e60 to
989589e
Compare
hikinggrass
added a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Cornelius Claussen <[email protected]> Co-authored-by: Kai Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Soft over current detection triggers when the EV draws more current then the PWM limit for several seconds. The current implementation checked the EV's current against the internally set current limit, which may be different from the PWM signalled current limit for up to 5 seconds (as IEC allows PWM updates only every 5 seconds).
If PWM is changed frequently (e.g. due to solar charging) this may lead to unintended over current triggers (it takes 5 seconds for the PWM to change and another 6s or so for some EVs to actually reduce current).
With this PR, the OC detection is based on the current actually signalled on the PWM for basic AC charging.
Issue ticket number and link
Checklist before requesting a review