Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Trigger validation only when useful #734

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Jun 21, 2024

Describe your changes

  • Added handling in Auth handler to only trigger validation callbacks when it is useful
  • In some situations it can be determined that no validation is necessary because no connector is available or requested token does not match a present reservation

Fixes the following OCTT1.6 test cases:

  • TC_046_1_CS
  • TC_068_CS

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

… when it is useful

* In some situations it can be determined that no validation is necessary because no connector is available or requested token does not match a present reservation

Signed-off-by: pietfried <[email protected]>
@Pietfried Pietfried merged commit 65a8cee into main Jun 26, 2024
7 of 8 checks passed
@Pietfried Pietfried deleted the feature/auth-only-validate-if-useful branch June 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants